-
-
Notifications
You must be signed in to change notification settings - Fork 928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support more than four watch faces #1055
Comments
For reference: In the Infineat PR https://github.com/InfiniTimeOrg/InfiniTime/pull/1024/files#diff-9a831e18eb55ca2a71cd4c049332c67dcb0d7607109ebddf043757e5276b4f43 @dmlls created a |
Started to look into this as well for the step meter analog face. Wouldn't something like the lv_roller widget be better suited (and not have any complexity with the multiple screens and control handling? I think the CheckBoxList will work well for many multi-selections, but in the case of radio button (single selections) I think it's a bit overkill... Something to discuss and see what people think? EDIT: Had a quick play with roller, and there are conflicting swipe events for returning from settings screens. These of course could be overriden, but sort of breaks the entire feel of the screens - Suppose that's a reason not to do a roller. Dropdown is also a possible consideration... |
I've just created a more generic feature request about dynamic app and custom watchface to group multiple requests around that topic. Feel free to continue the discussion in #1262 ;-) |
Verification
What happened?
On Watch Face selection screen entries flow off the bottom
What should happen instead?
Watch Face selection screen should scroll
Reproduction steps
In files SettingWatchFace.cpp and SettingWatchFace.h adding another watch face after the four existing watch faces causes the fifth watch face to show only half the name and button at the bottom of the screen. A sixth watch face would not show at all. In terms of code changing:
static constexpr std::array<const char*, 4> options = {" Digital face", " Analog face", " PineTimeStyle", " Terminal"};
to:
static constexpr std::array<const char*, 5> options = {" Digital face", " Analog face", " PineTimeStyle", " Terminal", " Weather face"};
causes "Weather face" to only show half the text and button at the bottom of the screen.
More details?
Even though the fifth watch face button and name are only half shown on the bottom of the screen it is still selectable. I have done nothing to try and fix it.
Version
1.8.0
Companion app
No response
The text was updated successfully, but these errors were encountered: