Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swipe to remove new notification #1232

Closed
1 task done
ghost opened this issue Jul 11, 2022 · 5 comments
Closed
1 task done

swipe to remove new notification #1232

ghost opened this issue Jul 11, 2022 · 5 comments

Comments

@ghost
Copy link

ghost commented Jul 11, 2022

Verification

  • I searched for similar feature request and found none was relevant.

Pitch us your idea!

new notification dismissable by swipe while preview is shown

Description

While dismissing notifications works fine while in the notification screen, I would like to be able to instantly dismiss a new notification during the time it gets shown on the display and (if possible) also return to the previous screen.

Currently to dismiss a notification which just came in, I have to:
0. receive notification

  1. swipe up to show home
  2. swipe down to show notifications
  3. swipe right to dismiss the notification
  4. swipe up to show home
  5. (navigate to previous app)

My proposal would make it as following:
0. receive notification

  1. swipe right to dismiss
  2. (navigate to previous app)
@devnoname120
Copy link

devnoname120 commented Jul 12, 2022

cc @NeroBurner

@SlidingHorn
Copy link

Hey all - I'm just curious if this is planned to make it into 1.12 - it's a feature I'd love to have, as it's a pain to have to make extraneous swipes (down, then up, then down, then right) rather than being able to dismiss the new notification outright. I see that originally #1245 was created and closed in favor of #1332, which (as far as my non-developer eyes can see) looks ready to merge.

Any updates or insight?

Thanks in advance, and thanks for all the hard work you all do here. Love my PineTime and Infinitime!

@devnoname120
Copy link

I've also been using this PR for a while without any issue.

@NeroBurner
Copy link
Contributor

@SlidingHorn from my point of view, yes. I'd like to see this improvement in 1.12. The limiting factor is time, especially from the maintainers, as we all do InfiniTime in our free time. But I think (as I've seen no road-block) nothing else is blocking this feature

@Riksu9000
Copy link
Contributor

This has been implemented with #1332 and #1350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants