Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since 3.6.0 AutoEncoder does not take quality as a constructor parameter #1332

Closed
karlomikus opened this issue Apr 22, 2024 · 5 comments
Closed
Assignees

Comments

@karlomikus
Copy link

Describe the bug
Not sure if this is breaking change, but if you follow docs, the examples are not correct anymore: https://image.intervention.io/v3/basics/image-output#encoding-images

Code Example
The following code is not working anymore:

$encodedImage = $image->encode(new AutoEncoder(quality: 85));

Environment (please complete the following information):

  • PHP Version: 8.2.0
  • OS: Ubuntu
  • Intervention Image Version: 3.6.0
  • GD or Imagick: Imagick
@olivervogel
Copy link
Member

Thanks for reporting. Unfortunately I can't reproduce this at the moment. What is the error message you are getting?

@karlomikus
Copy link
Author

This happens when I try to encode .png image.

[2024-04-22 14:11:41] local.ERROR: [IMAGE_SERVICE] Unknown named parameter $quality  

I guess this happens because PngEncoder does not have $quality parameter.

@olivervogel
Copy link
Member

olivervogel commented Apr 22, 2024

Ok, I understand the problem. This needs to be adressed, I will look into it.

@olivervogel
Copy link
Member

This should be fixed in 3.6.1.

@karlomikus
Copy link
Author

I did some tests and they are all passing, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants