From b01eb1cea539335eb3fe66157b347d8b57b4acdc Mon Sep 17 00:00:00 2001 From: Oliver Vogel Date: Mon, 22 Apr 2024 17:06:04 +0200 Subject: [PATCH 01/11] Filter out parameter that to not match to target encoder --- src/Format.php | 37 +++++++++++++++++++++++++++---------- 1 file changed, 27 insertions(+), 10 deletions(-) diff --git a/src/Format.php b/src/Format.php index 3b81b1cd..17ca6d62 100644 --- a/src/Format.php +++ b/src/Format.php @@ -16,6 +16,7 @@ use Intervention\Image\Encoders\WebpEncoder; use Intervention\Image\Exceptions\NotSupportedException; use Intervention\Image\Interfaces\EncoderInterface; +use ReflectionClass; enum Format { @@ -95,16 +96,32 @@ public function fileExtensions(): array */ public function encoder(mixed ...$options): EncoderInterface { - return match ($this) { - self::AVIF => new AvifEncoder(...$options), - self::BMP => new BmpEncoder(...$options), - self::GIF => new GifEncoder(...$options), - self::HEIC => new HeicEncoder(...$options), - self::JP2 => new Jpeg2000Encoder(...$options), - self::JPEG => new JpegEncoder(...$options), - self::PNG => new PngEncoder(...$options), - self::TIFF => new TiffEncoder(...$options), - self::WEBP => new WebpEncoder(...$options), + $classname = match ($this) { + self::AVIF => AvifEncoder::class, + self::BMP => BmpEncoder::class, + self::GIF => GifEncoder::class, + self::HEIC => HeicEncoder::class, + self::JP2 => Jpeg2000Encoder::class, + self::JPEG => JpegEncoder::class, + self::PNG => PngEncoder::class, + self::TIFF => TiffEncoder::class, + self::WEBP => WebpEncoder::class, }; + + // get allowed parameters of target encoder + $parameters = []; + $reflectionClass = new ReflectionClass($classname); + if ($constructor = $reflectionClass->getConstructor()) { + foreach ($constructor->getParameters() as $parameter) { + $parameters[] = $parameter->getName(); + } + } + + // filter only allowed options + $options = array_filter($options, function ($key) use ($parameters) { + return in_array($key, $parameters); + }, ARRAY_FILTER_USE_KEY); + + return new $classname(...$options); } } From f4b377e1d7402bb23000e534fa5cfc60a357a70a Mon Sep 17 00:00:00 2001 From: Oliver Vogel Date: Mon, 22 Apr 2024 17:44:32 +0200 Subject: [PATCH 02/11] Refactor to arrow function --- src/Format.php | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/Format.php b/src/Format.php index 17ca6d62..44014288 100644 --- a/src/Format.php +++ b/src/Format.php @@ -112,9 +112,10 @@ public function encoder(mixed ...$options): EncoderInterface $parameters = []; $reflectionClass = new ReflectionClass($classname); if ($constructor = $reflectionClass->getConstructor()) { - foreach ($constructor->getParameters() as $parameter) { - $parameters[] = $parameter->getName(); - } + $parameters = array_map( + fn ($parameter) => $parameter->getName(), + $constructor->getParameters(), + ); } // filter only allowed options From a618334d2ac55eed1064908231b1cdd74e6df9c8 Mon Sep 17 00:00:00 2001 From: Oliver Vogel Date: Mon, 22 Apr 2024 17:49:12 +0200 Subject: [PATCH 03/11] Refactor to arrow function --- src/Format.php | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/Format.php b/src/Format.php index 44014288..b8b8b8f2 100644 --- a/src/Format.php +++ b/src/Format.php @@ -119,9 +119,7 @@ public function encoder(mixed ...$options): EncoderInterface } // filter only allowed options - $options = array_filter($options, function ($key) use ($parameters) { - return in_array($key, $parameters); - }, ARRAY_FILTER_USE_KEY); + $options = array_filter($options, fn ($key) => in_array($key, $parameters), ARRAY_FILTER_USE_KEY); return new $classname(...$options); } From 171121bf7d1ca82af2f0b698345a5de9b526a0d8 Mon Sep 17 00:00:00 2001 From: Oliver Vogel Date: Mon, 22 Apr 2024 17:49:40 +0200 Subject: [PATCH 04/11] Reformat code --- src/Format.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/Format.php b/src/Format.php index b8b8b8f2..4bfaaf1c 100644 --- a/src/Format.php +++ b/src/Format.php @@ -119,7 +119,11 @@ public function encoder(mixed ...$options): EncoderInterface } // filter only allowed options - $options = array_filter($options, fn ($key) => in_array($key, $parameters), ARRAY_FILTER_USE_KEY); + $options = array_filter( + $options, + fn ($key) => in_array($key, $parameters), + ARRAY_FILTER_USE_KEY, + ); return new $classname(...$options); } From 86ab9025256b29083ec65a17fa28fcec0184cccc Mon Sep 17 00:00:00 2001 From: Oliver Vogel Date: Mon, 22 Apr 2024 17:56:21 +0200 Subject: [PATCH 05/11] Add MediaTypeEncoderTest --- tests/Unit/Encoders/MediaTypeEncoderTest.php | 138 +++++++++++++++++++ 1 file changed, 138 insertions(+) create mode 100644 tests/Unit/Encoders/MediaTypeEncoderTest.php diff --git a/tests/Unit/Encoders/MediaTypeEncoderTest.php b/tests/Unit/Encoders/MediaTypeEncoderTest.php new file mode 100644 index 00000000..b0461f75 --- /dev/null +++ b/tests/Unit/Encoders/MediaTypeEncoderTest.php @@ -0,0 +1,138 @@ +encoderByMediaType($mediaType); + } + }; + + return $encoder->test($mediaType); + } + + public function testEncoderByFileExtensionString(): void + { + $this->assertInstanceOf( + WebpEncoder::class, + $this->testEncoder('image/webp') + ); + + $this->assertInstanceOf( + AvifEncoder::class, + $this->testEncoder('image/avif') + ); + + $this->assertInstanceOf( + JpegEncoder::class, + $this->testEncoder('image/jpeg') + ); + + $this->assertInstanceOf( + BmpEncoder::class, + $this->testEncoder('image/bmp') + ); + + $this->assertInstanceOf( + GifEncoder::class, + $this->testEncoder('image/gif') + ); + + $this->assertInstanceOf( + PngEncoder::class, + $this->testEncoder('image/png') + ); + + $this->assertInstanceOf( + TiffEncoder::class, + $this->testEncoder('image/tiff') + ); + + $this->assertInstanceOf( + Jpeg2000Encoder::class, + $this->testEncoder('image/jp2') + ); + + $this->assertInstanceOf( + HeicEncoder::class, + $this->testEncoder('image/heic') + ); + } + + public function testEncoderByFileExtensionEnumMember(): void + { + $this->assertInstanceOf( + WebpEncoder::class, + $this->testEncoder(MediaType::IMAGE_WEBP) + ); + + $this->assertInstanceOf( + AvifEncoder::class, + $this->testEncoder(MediaType::IMAGE_AVIF) + ); + + $this->assertInstanceOf( + JpegEncoder::class, + $this->testEncoder(MediaType::IMAGE_JPG) + ); + + $this->assertInstanceOf( + BmpEncoder::class, + $this->testEncoder(MediaType::IMAGE_BMP) + ); + + $this->assertInstanceOf( + GifEncoder::class, + $this->testEncoder(MediaType::IMAGE_GIF) + ); + + $this->assertInstanceOf( + PngEncoder::class, + $this->testEncoder(MediaType::IMAGE_PNG) + ); + + $this->assertInstanceOf( + TiffEncoder::class, + $this->testEncoder(MediaType::IMAGE_TIFF) + ); + + $this->assertInstanceOf( + Jpeg2000Encoder::class, + $this->testEncoder(MediaType::IMAGE_JP2) + ); + + $this->assertInstanceOf( + HeicEncoder::class, + $this->testEncoder(MediaType::IMAGE_HEIC) + ); + } + + public function testEncoderByFileExtensionUnknown(): void + { + $this->expectException(EncoderException::class); + $this->testEncoder('test'); + } +} From 59149a339801d7a3932c6da290423753bdd8c6cf Mon Sep 17 00:00:00 2001 From: Oliver Vogel Date: Mon, 22 Apr 2024 18:10:18 +0200 Subject: [PATCH 06/11] Add MediaTypeEncoderTest --- tests/Unit/Encoders/MediaTypeEncoderTest.php | 121 +++++-------------- 1 file changed, 30 insertions(+), 91 deletions(-) diff --git a/tests/Unit/Encoders/MediaTypeEncoderTest.php b/tests/Unit/Encoders/MediaTypeEncoderTest.php index b0461f75..3d23c649 100644 --- a/tests/Unit/Encoders/MediaTypeEncoderTest.php +++ b/tests/Unit/Encoders/MediaTypeEncoderTest.php @@ -18,13 +18,19 @@ use Intervention\Image\Interfaces\EncoderInterface; use Intervention\Image\MediaType; use Intervention\Image\Tests\BaseTestCase; +use PHPUnit\Framework\Attributes\DataProvider; final class MediaTypeEncoderTest extends BaseTestCase { - private function testEncoder(string|MediaType $mediaType): EncoderInterface + private function testEncoder(string|MediaType $mediaType, array $options = []): EncoderInterface { - $encoder = new class () extends MediaTypeEncoder + $encoder = new class ($mediaType, ...$options) extends MediaTypeEncoder { + public function __construct($mediaType, ...$options) + { + parent::__construct($mediaType, ...$options); + } + public function test($mediaType) { return $this->encoderByMediaType($mediaType); @@ -34,102 +40,35 @@ public function test($mediaType) return $encoder->test($mediaType); } - public function testEncoderByFileExtensionString(): void - { - $this->assertInstanceOf( - WebpEncoder::class, - $this->testEncoder('image/webp') - ); - - $this->assertInstanceOf( - AvifEncoder::class, - $this->testEncoder('image/avif') - ); - - $this->assertInstanceOf( - JpegEncoder::class, - $this->testEncoder('image/jpeg') - ); - - $this->assertInstanceOf( - BmpEncoder::class, - $this->testEncoder('image/bmp') - ); - - $this->assertInstanceOf( - GifEncoder::class, - $this->testEncoder('image/gif') - ); - - $this->assertInstanceOf( - PngEncoder::class, - $this->testEncoder('image/png') - ); - - $this->assertInstanceOf( - TiffEncoder::class, - $this->testEncoder('image/tiff') - ); - - $this->assertInstanceOf( - Jpeg2000Encoder::class, - $this->testEncoder('image/jp2') - ); - + #[DataProvider('targetEncoderProvider')] + public function testEncoderByFileExtensionString( + string $mediaType, + string $targetEncoderClassname, + array $options, + ): void { $this->assertInstanceOf( - HeicEncoder::class, - $this->testEncoder('image/heic') + $targetEncoderClassname, + $this->testEncoder($mediaType, $options) ); } - public function testEncoderByFileExtensionEnumMember(): void + public static function targetEncoderProvider(): array { - $this->assertInstanceOf( - WebpEncoder::class, - $this->testEncoder(MediaType::IMAGE_WEBP) - ); - - $this->assertInstanceOf( - AvifEncoder::class, - $this->testEncoder(MediaType::IMAGE_AVIF) - ); - - $this->assertInstanceOf( - JpegEncoder::class, - $this->testEncoder(MediaType::IMAGE_JPG) - ); - - $this->assertInstanceOf( - BmpEncoder::class, - $this->testEncoder(MediaType::IMAGE_BMP) - ); - - $this->assertInstanceOf( - GifEncoder::class, - $this->testEncoder(MediaType::IMAGE_GIF) - ); - - $this->assertInstanceOf( - PngEncoder::class, - $this->testEncoder(MediaType::IMAGE_PNG) - ); - - $this->assertInstanceOf( - TiffEncoder::class, - $this->testEncoder(MediaType::IMAGE_TIFF) - ); - - $this->assertInstanceOf( - Jpeg2000Encoder::class, - $this->testEncoder(MediaType::IMAGE_JP2) - ); - - $this->assertInstanceOf( - HeicEncoder::class, - $this->testEncoder(MediaType::IMAGE_HEIC) - ); + return [ + ['image/webp', WebpEncoder::class, []], + ['image/avif', AvifEncoder::class, []], + ['image/jpeg', JpegEncoder::class, []], + ['image/bmp', BmpEncoder::class, []], + ['image/gif', GifEncoder::class, []], + ['image/png', PngEncoder::class, []], + ['image/png', PngEncoder::class, ['quality' => 10]], + ['image/tiff', TiffEncoder::class, []], + ['image/jp2', Jpeg2000Encoder::class, []], + ['image/heic', HeicEncoder::class, []], + ]; } + public function testEncoderByFileExtensionUnknown(): void { $this->expectException(EncoderException::class); From 9b3abba1614eab4071cb8a95c571ca15997e3949 Mon Sep 17 00:00:00 2001 From: Oliver Vogel Date: Mon, 22 Apr 2024 18:17:58 +0200 Subject: [PATCH 07/11] Add negative test --- tests/Unit/Encoders/MediaTypeEncoderTest.php | 36 +++++++++++++------- 1 file changed, 24 insertions(+), 12 deletions(-) diff --git a/tests/Unit/Encoders/MediaTypeEncoderTest.php b/tests/Unit/Encoders/MediaTypeEncoderTest.php index 3d23c649..4d9ea21c 100644 --- a/tests/Unit/Encoders/MediaTypeEncoderTest.php +++ b/tests/Unit/Encoders/MediaTypeEncoderTest.php @@ -44,30 +44,42 @@ public function test($mediaType) public function testEncoderByFileExtensionString( string $mediaType, string $targetEncoderClassname, - array $options, ): void { $this->assertInstanceOf( $targetEncoderClassname, - $this->testEncoder($mediaType, $options) + $this->testEncoder($mediaType) ); } public static function targetEncoderProvider(): array { return [ - ['image/webp', WebpEncoder::class, []], - ['image/avif', AvifEncoder::class, []], - ['image/jpeg', JpegEncoder::class, []], - ['image/bmp', BmpEncoder::class, []], - ['image/gif', GifEncoder::class, []], - ['image/png', PngEncoder::class, []], - ['image/png', PngEncoder::class, ['quality' => 10]], - ['image/tiff', TiffEncoder::class, []], - ['image/jp2', Jpeg2000Encoder::class, []], - ['image/heic', HeicEncoder::class, []], + ['image/webp', WebpEncoder::class], + ['image/avif', AvifEncoder::class], + ['image/jpeg', JpegEncoder::class], + ['image/bmp', BmpEncoder::class], + ['image/gif', GifEncoder::class], + ['image/png', PngEncoder::class], + ['image/png', PngEncoder::class], + ['image/tiff', TiffEncoder::class], + ['image/jp2', Jpeg2000Encoder::class], + ['image/heic', HeicEncoder::class], ]; } + public function testArgumentsNotSupportedByTargetEncoder(): void + { + $encoder = $this->testEncoder( + 'image/png', + [ + 'interlaced' => true, // is not ignored + 'quality' => 10, // is ignored because png encoder has no quality argument + ], + ); + + $this->assertInstanceOf(PngEncoder::class, $encoder); + $this->assertTrue($encoder->interlaced); + } public function testEncoderByFileExtensionUnknown(): void { From 53219e217b5cbc9abf0150e5fac1da59796aacde Mon Sep 17 00:00:00 2001 From: Oliver Vogel Date: Mon, 22 Apr 2024 19:24:30 +0200 Subject: [PATCH 08/11] Correct method name --- src/Format.php | 4 ++-- tests/Unit/Encoders/MediaTypeEncoderTest.php | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Format.php b/src/Format.php index 4bfaaf1c..852891d5 100644 --- a/src/Format.php +++ b/src/Format.php @@ -108,7 +108,7 @@ public function encoder(mixed ...$options): EncoderInterface self::WEBP => WebpEncoder::class, }; - // get allowed parameters of target encoder + // get parameters of target encoder $parameters = []; $reflectionClass = new ReflectionClass($classname); if ($constructor = $reflectionClass->getConstructor()) { @@ -118,7 +118,7 @@ public function encoder(mixed ...$options): EncoderInterface ); } - // filter only allowed options + // filter out unavailable options for target encoder $options = array_filter( $options, fn ($key) => in_array($key, $parameters), diff --git a/tests/Unit/Encoders/MediaTypeEncoderTest.php b/tests/Unit/Encoders/MediaTypeEncoderTest.php index 4d9ea21c..0119b7ac 100644 --- a/tests/Unit/Encoders/MediaTypeEncoderTest.php +++ b/tests/Unit/Encoders/MediaTypeEncoderTest.php @@ -41,7 +41,7 @@ public function test($mediaType) } #[DataProvider('targetEncoderProvider')] - public function testEncoderByFileExtensionString( + public function testEncoderByMediaType( string $mediaType, string $targetEncoderClassname, ): void { From 71b5cf2f9c197a23fd310906373ef4731781ff5f Mon Sep 17 00:00:00 2001 From: Oliver Vogel Date: Mon, 22 Apr 2024 19:37:22 +0200 Subject: [PATCH 09/11] Add tests --- .../Encoders/FileExtensionEncoderTest.php | 138 +++++++----------- tests/Unit/Encoders/MediaTypeEncoderTest.php | 12 +- 2 files changed, 61 insertions(+), 89 deletions(-) diff --git a/tests/Unit/Encoders/FileExtensionEncoderTest.php b/tests/Unit/Encoders/FileExtensionEncoderTest.php index 8d111b98..4e28d9fc 100644 --- a/tests/Unit/Encoders/FileExtensionEncoderTest.php +++ b/tests/Unit/Encoders/FileExtensionEncoderTest.php @@ -18,13 +18,19 @@ use Intervention\Image\FileExtension; use Intervention\Image\Interfaces\EncoderInterface; use Intervention\Image\Tests\BaseTestCase; +use PHPUnit\Framework\Attributes\DataProvider; final class FileExtensionEncoderTest extends BaseTestCase { - private function testEncoder(string|FileExtension $extension): EncoderInterface + private function testEncoder(string|FileExtension $extension, array $options = []): EncoderInterface { - $encoder = new class () extends FileExtensionEncoder + $encoder = new class ($extension, ...$options) extends FileExtensionEncoder { + public function __construct($mediaType, ...$options) + { + parent::__construct($mediaType, ...$options); + } + public function test($extension) { return $this->encoderByFileExtension($extension); @@ -34,100 +40,56 @@ public function test($extension) return $encoder->test($extension); } - public function testEncoderByFileExtensionString(): void - { - $this->assertInstanceOf( - WebpEncoder::class, - $this->testEncoder('webp') - ); - + #[DataProvider('targetEncoderProvider')] + public function testEncoderByFileExtensionString( + string|FileExtension $fileExtension, + string $targetEncoderClassname, + ): void { $this->assertInstanceOf( - AvifEncoder::class, - $this->testEncoder('avif') - ); - - $this->assertInstanceOf( - JpegEncoder::class, - $this->testEncoder('jpeg') - ); - - $this->assertInstanceOf( - BmpEncoder::class, - $this->testEncoder('bmp') - ); - - $this->assertInstanceOf( - GifEncoder::class, - $this->testEncoder('gif') - ); - - $this->assertInstanceOf( - PngEncoder::class, - $this->testEncoder('png') - ); - - $this->assertInstanceOf( - TiffEncoder::class, - $this->testEncoder('tiff') - ); - - $this->assertInstanceOf( - Jpeg2000Encoder::class, - $this->testEncoder('jp2') - ); - - $this->assertInstanceOf( - HeicEncoder::class, - $this->testEncoder('heic') + $targetEncoderClassname, + $this->testEncoder($fileExtension), ); } - public function testEncoderByFileExtensionEnumMember(): void + public static function targetEncoderProvider(): array { - $this->assertInstanceOf( - WebpEncoder::class, - $this->testEncoder(FileExtension::WEBP) - ); - - $this->assertInstanceOf( - AvifEncoder::class, - $this->testEncoder(FileExtension::AVIF) - ); - - $this->assertInstanceOf( - JpegEncoder::class, - $this->testEncoder(FileExtension::JPG) - ); - - $this->assertInstanceOf( - BmpEncoder::class, - $this->testEncoder(FileExtension::BMP) - ); - - $this->assertInstanceOf( - GifEncoder::class, - $this->testEncoder(FileExtension::GIF) - ); - - $this->assertInstanceOf( - PngEncoder::class, - $this->testEncoder(FileExtension::PNG) - ); - - $this->assertInstanceOf( - TiffEncoder::class, - $this->testEncoder(FileExtension::TIF) - ); + return [ + ['webp', WebpEncoder::class], + ['avif', AvifEncoder::class], + ['jpeg', JpegEncoder::class], + ['jpg', JpegEncoder::class], + ['bmp', BmpEncoder::class], + ['gif', GifEncoder::class], + ['png', PngEncoder::class], + ['tiff', TiffEncoder::class], + ['tif', TiffEncoder::class], + ['jp2', Jpeg2000Encoder::class], + ['heic', HeicEncoder::class], + [FileExtension::WEBP, WebpEncoder::class], + [FileExtension::AVIF, AvifEncoder::class], + [FileExtension::JPG, JpegEncoder::class], + [FileExtension::BMP, BmpEncoder::class], + [FileExtension::GIF, GifEncoder::class], + [FileExtension::PNG, PngEncoder::class], + [FileExtension::TIF, TiffEncoder::class], + [FileExtension::TIFF, TiffEncoder::class], + [FileExtension::JP2, Jpeg2000Encoder::class], + [FileExtension::HEIC, HeicEncoder::class], + ]; + } - $this->assertInstanceOf( - Jpeg2000Encoder::class, - $this->testEncoder(FileExtension::JPG2) + public function testArgumentsNotSupportedByTargetEncoder(): void + { + $encoder = $this->testEncoder( + 'png', + [ + 'interlaced' => true, // is not ignored + 'quality' => 10, // is ignored because png encoder has no quality argument + ], ); - $this->assertInstanceOf( - HeicEncoder::class, - $this->testEncoder(FileExtension::HEIC) - ); + $this->assertInstanceOf(PngEncoder::class, $encoder); + $this->assertTrue($encoder->interlaced); } public function testEncoderByFileExtensionUnknown(): void diff --git a/tests/Unit/Encoders/MediaTypeEncoderTest.php b/tests/Unit/Encoders/MediaTypeEncoderTest.php index 0119b7ac..713611ac 100644 --- a/tests/Unit/Encoders/MediaTypeEncoderTest.php +++ b/tests/Unit/Encoders/MediaTypeEncoderTest.php @@ -42,7 +42,7 @@ public function test($mediaType) #[DataProvider('targetEncoderProvider')] public function testEncoderByMediaType( - string $mediaType, + string|MediaType $mediaType, string $targetEncoderClassname, ): void { $this->assertInstanceOf( @@ -64,6 +64,16 @@ public static function targetEncoderProvider(): array ['image/tiff', TiffEncoder::class], ['image/jp2', Jpeg2000Encoder::class], ['image/heic', HeicEncoder::class], + [MediaType::IMAGE_WEBP, WebpEncoder::class], + [MediaType::IMAGE_AVIF, AvifEncoder::class], + [MediaType::IMAGE_JPEG, JpegEncoder::class], + [MediaType::IMAGE_BMP, BmpEncoder::class], + [MediaType::IMAGE_GIF, GifEncoder::class], + [MediaType::IMAGE_PNG, PngEncoder::class], + [MediaType::IMAGE_TIFF, TiffEncoder::class], + [MediaType::IMAGE_JP2, Jpeg2000Encoder::class], + [MediaType::IMAGE_HEIC, HeicEncoder::class], + [MediaType::IMAGE_HEIF, HeicEncoder::class], ]; } From acf0bd259b6b91cd871fb6fccf5cc82f75b9c82b Mon Sep 17 00:00:00 2001 From: Oliver Vogel Date: Tue, 23 Apr 2024 16:09:24 +0200 Subject: [PATCH 10/11] Change method description --- src/Format.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Format.php b/src/Format.php index 1402db2f..2c8cdb55 100644 --- a/src/Format.php +++ b/src/Format.php @@ -89,7 +89,7 @@ public function fileExtensions(): array } /** - * Create an encoder instance that matches the format + * Create an encoder instance with given options that matches the format * * @param mixed $options * @return EncoderInterface From 6c372473ac8ea45a198b89681cab1408942fde92 Mon Sep 17 00:00:00 2001 From: Oliver Vogel Date: Tue, 23 Apr 2024 16:11:56 +0200 Subject: [PATCH 11/11] Change code comments --- src/Format.php | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Format.php b/src/Format.php index 2c8cdb55..da48a116 100644 --- a/src/Format.php +++ b/src/Format.php @@ -96,6 +96,7 @@ public function fileExtensions(): array */ public function encoder(mixed ...$options): EncoderInterface { + // get classname of target encoder from current format $classname = match ($this) { self::AVIF => AvifEncoder::class, self::BMP => BmpEncoder::class, @@ -118,7 +119,7 @@ public function encoder(mixed ...$options): EncoderInterface ); } - // filter out unavailable options for target encoder + // filter out unavailable options of target encoder $options = array_filter( $options, fn ($key) => in_array($key, $parameters),