Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not remove the trigger characters in *.cshtml files #19

Closed
SimonePaolo opened this issue Dec 20, 2020 · 2 comments
Closed

Does not remove the trigger characters in *.cshtml files #19

SimonePaolo opened this issue Dec 20, 2020 · 2 comments
Assignees
Labels
Type: Bug Something isn't working

Comments

@SimonePaolo
Copy link

Dear Janne, thank you for the extension.

VSCode Version: 1.52.1
Font Awesome Auto-complete & Preview Version: 1.1.1

The extension does not remove the trigger characters in *.cshtml files. It works fine with *.html files.
It does not remove "fa-" from "fa-fas":

I have only this setting:
"fontAwesomeAutocomplete.patterns": [
"/*.cshtml", "/*.html"]

I'm making something wrong?

@Janne252 Janne252 added the Type: Bug Something isn't working label Dec 20, 2020
@Janne252 Janne252 self-assigned this Dec 20, 2020
@Janne252
Copy link
Owner

Thanks for the report. It appears the default pattern for disabling the removal of trigger word **/*.html also incorrectly matches .cshtml files. The dot (.) in the pattern was never escaped. This is now fixed.

Version 1.1.2 is now available on all platforms.

@SimonePaolo
Copy link
Author

It works!
Thank you very much for the fast update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants