Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

header option for $network.request action not working #42

Open
amankumarjain opened this issue Mar 28, 2017 · 2 comments
Open

header option for $network.request action not working #42

amankumarjain opened this issue Mar 28, 2017 · 2 comments

Comments

@amankumarjain
Copy link

amankumarjain commented Mar 28, 2017

{ "type": "$network.request", "options": { "url": "http://www.jasonbase.com/messages.json", "method": "post", "data": { "user_id": "fI9", "message": "Hello there" }, "header": { "auth_token": "fnekfla98dls9sNFK0nf3" } }, "success": { "type": "$render" }, "error": { "type": "$util.alert", "options": { "title": "Error", "description": "Uh oh, something went wrong" } } }

In the previous code, if we pass header with this request, it doesnot add header.
Android File: JasonNetworkAction, header option condition is not handelled.

can i do pull request to patch this issue?

@gliechtenstein
Copy link
Contributor

This should be fixed with the latest develop branch. Could you retry and let me know if that works? You can get it here https://github.com/Jasonette/JASONETTE-Android/archive/develop.zip

@gliechtenstein
Copy link
Contributor

Oh i had totally missed the part where you asked if you can do a pull request.

This time I just went ahead and fixed it, but in the future please feel free to send a PR anytime if you see something wrong. Totally appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants