Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on nightly (Julia 1.6) #112

Closed
akabla opened this issue Apr 13, 2021 · 0 comments · Fixed by #119
Closed

Fail on nightly (Julia 1.6) #112

akabla opened this issue Apr 13, 2021 · 0 comments · Fixed by #119
Labels
bug Something isn't working

Comments

@akabla
Copy link
Member

akabla commented Apr 13, 2021

RHEOS is currently failing on nightly.

This does not seem to be RHEOS related.
The error is linked to the file dispatch.jl in MutableArithmetics, and to the function _iszero called there.

The file dispatch.jl currently states next to the _iszero call:

# This was fixed in https://github.com/JuliaLang/julia/pull/36194 but then reverted.
# Fixed again in https://github.com/JuliaLang/julia/pull/38789/ but not merged yet.
# To determine whether the funtion is zero preserving, `LinearAlgebra` calls
# `zero` on the `eltype` of the broadcasted object and then check `_iszero`.
# `_iszero(x)` redirects to `iszero(x)` for numbers and to `x == 0` otherwise.
# `x == 0` returns false for types that implement `iszero` but not `==` such as
# `DummyBigInt` and MOI functions.
LinearAlgebra._iszero(x::AbstractMutable) = iszero(x)

We may want to check this out.
JuliaLang/julia#38789

Hopefully fixes will make their way to us.

@akabla akabla added the bug Something isn't working label Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant