Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resample to accept RheoTimeData with only time data. #77

Closed
akabla opened this issue Jun 2, 2020 · 1 comment
Closed

resample to accept RheoTimeData with only time data. #77

akabla opened this issue Jun 2, 2020 · 1 comment
Assignees
@akabla
Labels
enhancement New feature or request
Milestone
0.9.4

Comments

@akabla
Copy link
Member

akabla commented Jun 2, 2020

This causes an error:

d=timeline(t_start=0, t_end=10, step = 0.4)
d=resample(d, 2)
ERROR: UndefVarError: sigma not defined

There is no reason not to accept a timeline in this function.

The error message when providing a float param could be more helpful too.

julia> d=resample(d, 2.)
ERROR: MethodError: no method matching resample(::RheoTimeData, ::Float64)
@akabla akabla added the enhancement New feature or request label Jun 2, 2020
@akabla akabla added this to the 0.9.4 milestone Jun 2, 2020
@akabla akabla self-assigned this Jun 2, 2020
@akabla akabla mentioned this issue Jun 2, 2020
Closed
@akabla
Copy link
Member Author

akabla commented Jun 6, 2020

Solve with 0eeba21

@akabla akabla closed this as completed Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akabla akabla

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.9.4
Development

No branches or pull requests
1 participant
@akabla