Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReshapedArrays support #771

Open
wants to merge 182 commits into
base: main
Choose a base branch
from
Open

ReshapedArrays support #771

wants to merge 182 commits into from

Conversation

gdalle
Copy link

@gdalle gdalle commented Aug 9, 2023

Fix #770

amontoison and others added 30 commits September 7, 2022 13:54
@amontoison
[KrylovSolvers] inner constructors -> outer constructors
ad1fab9
@amontoison
Add a reference to BiCG paper
7c5e233
@amontoison
Update src/bilq.jl
3cc80c6
@amontoison
[documentation] Add a section about preconditioners
69e7c1d
@amontoison
Add more details about preconditioned LS and LN problems
cce31e6
@amontoison
[documentation] Add more details about preconditioners
58a28db
@amontoison
Final version of preconditioners.md
08c0e1e
@amontoison
Fix tests with CGNE
016d6c6
@amontoison @dpo
Apply suggestions from @dpo
5d1a87f 
Co-authored-by: Dominique <dominique.orban@gmail.com>
@amontoison
Update test_solvers.jl
5d54847
@amontoison
Update preconditioners.md
c967453
@amontoison
fix \tfrac in preconditioners.jl
55cbe4e
@amontoison @dpo
Update docs/src/preconditioners.md
dd42770 
Co-authored-by: Dominique <dominique.orban@gmail.com>
@amontoison
A^T -> A^H
645e094
@amontoison
[documentation] Use Aᴴ instead of Aᵀ
330304a
@amontoison
[test] Use Aᴴ instead of Aᵀ
604c960
@amontoison
[code] Use Aᴴ instead of Aᵀ
73e95a7
@amontoison
Test Krylov macros
fc8677b
@amontoison
Use buildkite to test the GPU support
e7cd9b8
@amontoison
Update workflows
fc8bb59
@amontoison
Update CommentPR.yml
26c4856
@amontoison
[documentation] update gpu.md
b19c74b
@amontoison
[documentation] Test the code of GPU backends with buildkite
3c67dfb
@amontoison
Fix few typos
a97909a
@amontoison @dpo
Apply suggestions from code review
b5c2ea9 
Co-authored-by: Dominique <dominique.orban@gmail.com>
@amontoison
[GPU] Remove random tests
bcbc6aa
@amontoison
Add more examples with the preconditioners
db3520f
@amontoison
Update docs/src/preconditioners.md
6208825
@amontoison
Release 0.8.4
66e1fd1
@amontoison
[documentation] update callbacks.md
794483b
amontoison and others added 22 commits May 10, 2023 19:55
@amontoison
Fix my sed command
b22e980
@amontoison
Test the verbose mode
ba849b4
@amontoison
Take into account the time to allocate the KrylovSolver
5f7ea0f 
and perform warm-start when the timemax option is used
@amontoison
Update the verbose mode to display a timer
b62f606
@amontoison
Add a field timer in the statistics
55f577c
@amontoison
Update test_stats.jl
bd3e691
@amontoison
Update the KrylovSolvers to support the timer in KrylovStats
e2eb7c4
@amontoison
Update stats.timer in all Krylov methods
fa0da9c
@amontoison
Release 0.9.1
d6f3e51
@amontoison
Improve the reliability of solver.stats.timer
6d9def6
@amontoison
[CI] Remove the build with Linux ARM
0de0116
@amontoison
Optimize the generic function solve!
1a1c59f
@amontoison
Add methods solve! with optional arguments
dca42a5
@amontoison
Add tests for in-place methods with keyword arguments
b3804c9
@amontoison
Fix tests with Apple GPUs
f780b59
@amontoison
Use metaprogramming to reduce the code
69e446f
@amontoison
Update .builkite/pipeline.yml
896e4ed
@amontoison
Keep tests with AMDGPU.jl commented
4182209
@amontoison
Release 0.9.2
88f518b
@gdalle
ReshapedArrays support
b42f714
@gdalle
Add tests
5a41681
@gdalle
Only for reshaped arrays that are vectors
1d33fb6
@gdalle gdalle marked this pull request as draft August 9, 2023 16:58
@gdalle
Copy link
Author

gdalle commented Aug 9, 2023

Still a draft cause i want to see if I can preserve sparsity

@gdalle gdalle marked this pull request as ready for review August 9, 2023 17:05
@gdalle
Copy link
Author

gdalle commented Aug 9, 2023

Actually it makes no sense to preserve sparsity

@codecov
Copy link

codecov bot commented Aug 9, 2023 •
edited
Loading

Codecov Report

Patch coverage: 90.55% and no project coverage change.

Comparison is base (88f518b) 98.26% compared to head (1d33fb6) 98.26%.
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #771   +/-   ##
=======================================
  Coverage   98.26%   98.26%           
=======================================
  Files          39       39           
  Lines        7105     7107    +2     
=======================================
+ Hits         6982     6984    +2     
  Misses        123      123
Files Changed Coverage Δ
src/krylov_utils.jl 91.45% <90.55%> (+0.08%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Package name latest stable
CaNNOLeS.jl
DCISolver.jl
FletcherPenaltySolver.jl
JSOSolvers.jl
LLSModels.jl
LinearSolve.jl
Percival.jl
RipQP.jl

@amontoison
Copy link
Member

amontoison commented Oct 14, 2024 •
edited
Loading

@gdalle May I ask you to rebase your PR?
I didn't know that you opened a PR about the ReshapedArrays support.

Is it still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReshapedArrays support
6 participants
@gdalle @amontoison @JuliaRegistrator @tmigot @maleadt @goggle