Drop PyTorch 2.0 from the test matrix #20009

awaelchli · 2024-06-24T15:58:11Z

What does this PR do?

Removes support for PyTorch 2.0, to shift our support window with the PyTorch 2.4 release soon. In subsequent PRs I'll add testing for PyTorch 2.4.

Previous PR for reference: #19706

📚 Documentation preview 📚: https://pytorch-lightning--20009.org.readthedocs.build/en/20009/

cc @Borda @carmocca @justusschock @awaelchli

for more information, see https://pre-commit.ci

github-actions · 2024-06-30T14:16:21Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-13, lightning, 3.8, 2.1, oldest)	success	✅
pl-cpu (macOS-14, lightning, 3.10, 2.1)	success	✅
pl-cpu (macOS-14, lightning, 3.10, 2.2)	success	✅
pl-cpu (macOS-14, lightning, 3.10, 2.3)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 2.1, oldest)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.1)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.2)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.3)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 2.1, oldest)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.1)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.2)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.3)	success	✅
pl-cpu (macOS-14, pytorch, 3.8, 2.1)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 2.1)	success	✅
pl-cpu (windows-2022, pytorch, 3.8, 2.1)	success	✅
pl-cpu (macOS-12, pytorch, 3.11, 2.1)	success	✅
pl-cpu (ubuntu-22.04, pytorch, 3.11, 2.1)	success	✅
pl-cpu (windows-2022, pytorch, 3.11, 2.1)	success	✅

These checks are required after the changes to .github/workflows/ci-tests-pytorch.yml, requirements/fabric/base.txt, requirements/fabric/examples.txt, src/lightning/fabric/__init__.py, src/lightning/fabric/fabric.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/init.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/fabric/utilities/throughput.py, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/test.txt, src/lightning/pytorch/core/module.py, src/lightning/pytorch/demos/transformer.py, src/lightning/pytorch/loops/utilities.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/utilities/compile.py, tests/tests_pytorch/callbacks/test_throughput_monitor.py, tests/tests_pytorch/conftest.py, tests/tests_pytorch/deprecated_api/test_no_removal_version.py, tests/tests_pytorch/strategies/test_fsdp.py, tests/tests_pytorch/strategies/test_model_parallel_integration.py, tests/tests_pytorch/trainer/flags/test_inference_mode.py.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs) (testing Lightning \| latest)	success	✅
pytorch-lightning (GPUs) (testing PyTorch \| latest)	success	✅

These checks are required after the changes to requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/test.txt, src/lightning/pytorch/core/module.py, src/lightning/pytorch/demos/transformer.py, src/lightning/pytorch/loops/utilities.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/utilities/compile.py, tests/tests_pytorch/callbacks/test_throughput_monitor.py, tests/tests_pytorch/conftest.py, tests/tests_pytorch/deprecated_api/test_no_removal_version.py, tests/tests_pytorch/strategies/test_fsdp.py, tests/tests_pytorch/strategies/test_model_parallel_integration.py, tests/tests_pytorch/trainer/flags/test_inference_mode.py, requirements/fabric/base.txt, requirements/fabric/examples.txt, src/lightning/fabric/__init__.py, src/lightning/fabric/fabric.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/init.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/fabric/utilities/throughput.py.

🟢 pytorch_lightning: Benchmarks

Check ID	Status
lightning.Benchmarks	success	✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/test.txt, src/lightning/fabric/__init__.py, src/lightning/fabric/fabric.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/init.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/fabric/utilities/throughput.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/demos/transformer.py, src/lightning/pytorch/loops/utilities.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/utilities/compile.py.

🟢 fabric: Docs

Check ID	Status
docs-make (fabric, doctest)	success	✅
docs-make (fabric, html)	success	✅

These checks are required after the changes to src/lightning/fabric/__init__.py, src/lightning/fabric/fabric.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/init.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/fabric/utilities/throughput.py, docs/source-fabric/advanced/compile.rst, docs/source-fabric/advanced/model_init.rst, requirements/fabric/base.txt, requirements/fabric/examples.txt.

🟢 pytorch_lightning: Docs

Check ID	Status
docs-make (pytorch, doctest)	success	✅
docs-make (pytorch, html)	success	✅

These checks are required after the changes to src/lightning/pytorch/core/module.py, src/lightning/pytorch/demos/transformer.py, src/lightning/pytorch/loops/utilities.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/utilities/compile.py, docs/source-pytorch/advanced/compile.rst, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/test.txt.

🟢 pytorch_lightning: Docker

Check ID	Status
build-cuda (3.10, 2.1, 12.1.0)	success	✅
build-cuda (3.10, 2.2, 12.1.0)	success	✅
build-cuda (3.11, 2.1, 12.1.0)	success	✅
build-cuda (3.11, 2.2, 12.1.0)	success	✅
build-pl (3.10, 2.1, 12.1.0)	success	✅
build-pl (3.10, 2.2, 12.1.0)	success	✅
build-pl (3.11, 2.1, 12.1.0)	success	✅
build-pl (3.11, 2.2, 12.1.0)	success	✅

These checks are required after the changes to .github/workflows/docker-build.yml, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/test.txt, requirements/fabric/base.txt, requirements/fabric/examples.txt.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu (macOS-13, lightning, 3.8, 2.1, oldest)	success	✅
fabric-cpu (macOS-14, lightning, 3.11, 2.1)	success	✅
fabric-cpu (macOS-14, lightning, 3.11, 2.2)	success	✅
fabric-cpu (macOS-14, lightning, 3.10, 2.3)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 2.1, oldest)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.1)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.2)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.11, 2.3)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 2.1, oldest)	success	✅
fabric-cpu (windows-2022, lightning, 3.11, 2.1)	success	✅
fabric-cpu (windows-2022, lightning, 3.11, 2.2)	success	✅
fabric-cpu (windows-2022, lightning, 3.11, 2.3)	success	✅
fabric-cpu (macOS-14, fabric, 3.8, 2.1)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 2.1)	success	✅
fabric-cpu (windows-2022, fabric, 3.8, 2.1)	success	✅
fabric-cpu (macOS-12, fabric, 3.11, 2.1)	success	✅
fabric-cpu (ubuntu-22.04, fabric, 3.11, 2.1)	success	✅
fabric-cpu (windows-2022, fabric, 3.11, 2.1)	success	✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/examples.txt, src/lightning/fabric/__init__.py, src/lightning/fabric/fabric.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/init.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/fabric/utilities/throughput.py, tests/tests_fabric/conftest.py, tests/tests_fabric/plugins/precision/test_bitsandbytes.py, tests/tests_fabric/strategies/test_ddp_integration.py, tests/tests_fabric/strategies/test_fsdp.py, tests/tests_fabric/strategies/test_fsdp_integration.py, tests/tests_fabric/test_fabric.py, tests/tests_fabric/test_wrappers.py, tests/tests_fabric/utilities/test_init.py, tests/tests_fabric/utilities/test_throughput.py, .github/workflows/ci-tests-fabric.yml.

🟢 lightning_fabric: Azure GPU

Check ID	Status
lightning-fabric (GPUs) (testing Fabric \| latest)	success	✅
lightning-fabric (GPUs) (testing Lightning \| latest)	success	✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/examples.txt, src/lightning/fabric/__init__.py, src/lightning/fabric/fabric.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/init.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/fabric/utilities/throughput.py, tests/tests_fabric/conftest.py, tests/tests_fabric/plugins/precision/test_bitsandbytes.py, tests/tests_fabric/strategies/test_ddp_integration.py, tests/tests_fabric/strategies/test_fsdp.py, tests/tests_fabric/strategies/test_fsdp_integration.py, tests/tests_fabric/test_fabric.py, tests/tests_fabric/test_wrappers.py, tests/tests_fabric/utilities/test_init.py, tests/tests_fabric/utilities/test_throughput.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/test.txt, src/lightning/fabric/__init__.py, src/lightning/fabric/fabric.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/init.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/fabric/utilities/throughput.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/demos/transformer.py, src/lightning/pytorch/loops/utilities.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/utilities/compile.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.11)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.11)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.11)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.11)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.11)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.11)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.11)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.11)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.11)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.11)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.11)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.11)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.11)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.11)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.11)	success	✅

These checks are required after the changes to src/lightning/fabric/__init__.py, src/lightning/fabric/fabric.py, src/lightning/fabric/strategies/fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/init.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/fabric/utilities/throughput.py, src/lightning/pytorch/core/module.py, src/lightning/pytorch/demos/transformer.py, src/lightning/pytorch/loops/utilities.py, src/lightning/pytorch/strategies/fsdp.py, src/lightning/pytorch/trainer/connectors/logger_connector/result.py, src/lightning/pytorch/utilities/compile.py, requirements/fabric/base.txt, requirements/fabric/examples.txt, requirements/pytorch/base.txt, requirements/pytorch/examples.txt, requirements/pytorch/test.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

codecov · 2024-06-30T14:35:39Z

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59%. Comparing base (5636fe4) to head (cee6c3e).
Report is 73 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (5636fe4) and HEAD (cee6c3e). Click for more details.

HEAD has 29 uploads less than BASE

Flag BASE (5636fe4) HEAD (cee6c3e)

pytest 26 22

examples 10 0

app 10 0

tpu 2 0

lightning_app 3 0

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #20009     +/-   ##
=========================================
- Coverage      72%      59%    -13%     
=========================================
  Files         427      422      -5     
  Lines       35505    35362    -143     
=========================================
- Hits        25573    20725   -4848     
- Misses       9932    14637   +4705

Remove support for PyTorch 2.1

7c89e08

github-actions bot added docs Documentation related fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file labels Jun 24, 2024

pre-commit-ci bot and others added 2 commits June 24, 2024 16:00

[pre-commit.ci] auto fixes from pre-commit.com hooks

dc47754

for more information, see https://pre-commit.ci

fix import

e45f61c

awaelchli modified the milestone: 2.4 Jun 24, 2024

simplify

efa5da3

awaelchli force-pushed the tests/remove-pytorch-2.1 branch from 07a06d0 to efa5da3 Compare June 24, 2024 16:34

awaelchli changed the title ~~WIP: Remove support for PyTorch 2.1~~ Drop PyTorch 2.1 from the test matrix Jun 30, 2024

Merge branch 'master' into tests/remove-pytorch-2.1

ca3bbe0

awaelchli marked this pull request as ready for review June 30, 2024 14:15

awaelchli requested review from lantiga, Borda, tchaton and justusschock as code owners June 30, 2024 14:15

awaelchli changed the title ~~Drop PyTorch 2.1 from the test matrix~~ Drop PyTorch 2.0 from the test matrix Jun 30, 2024

matrix

96f3567

awaelchli requested a review from ethanwharris as a code owner June 30, 2024 16:37

github-actions bot added the ci Continuous Integration label Jun 30, 2024

drop docker build

04c9dba

github-actions bot added the dockers label Jun 30, 2024

Borda approved these changes Jun 30, 2024

View reviewed changes

mergify bot added the has conflicts label Jun 30, 2024

awaelchli added 2 commits June 30, 2024 22:34

bump old onnx min version

082ee5a

terminate torch.compile threads in 2.1

29d7ca1

Merge branch 'master' into tests/remove-pytorch-2.1

bf07c0b

mergify bot removed the has conflicts label Jun 30, 2024

awaelchli force-pushed the tests/remove-pytorch-2.1 branch from 053a288 to 1848d1c Compare June 30, 2024 20:47

awaelchli added 2 commits June 30, 2024 23:04

bump numpy min version

823fc52

terminate torch.compile threads in 2.1

fdedabf

awaelchli force-pushed the tests/remove-pytorch-2.1 branch from 1848d1c to fdedabf Compare June 30, 2024 21:09

awaelchli added 2 commits June 30, 2024 23:35

update checkgroup

c926721

update changelog

cee6c3e

awaelchli merged commit 14493c0 into master Jun 30, 2024
118 checks passed

awaelchli deleted the tests/remove-pytorch-2.1 branch June 30, 2024 22:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Drop PyTorch 2.0 from the test matrix #20009

Drop PyTorch 2.0 from the test matrix #20009

awaelchli commented Jun 24, 2024 •

edited

Loading

github-actions bot commented Jun 30, 2024 •

edited

Loading

codecov bot commented Jun 30, 2024 •

edited

Loading

Drop PyTorch 2.0 from the test matrix #20009

Drop PyTorch 2.0 from the test matrix #20009

Conversation

awaelchli commented Jun 24, 2024 • edited Loading

What does this PR do?

github-actions bot commented Jun 30, 2024 • edited Loading

⚡ Required checks status: All passing 🟢

Groups summary

codecov bot commented Jun 30, 2024 • edited Loading

Codecov Report

awaelchli commented Jun 24, 2024 •

edited

Loading

github-actions bot commented Jun 30, 2024 •

edited

Loading

codecov bot commented Jun 30, 2024 •

edited

Loading