Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup/Refactor: remove manta/calamari/dolphin specifier from chain-spec files #581

Open
Garandor opened this issue Jun 8, 2022 · 0 comments
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime A-manta Area: Issues and PRs related to the Manta Runtime A-runtime Area: Issues and PRs related to Runtimes C-good-first-issue Category: Good first issues P-low Priority: Low
Milestone

Comments

@Garandor
Copy link
Contributor

Garandor commented Jun 8, 2022

chain spec has the RT name mentioned in everythin, from constants to function names, e.g. dolphin_development_config
see

pub fn manta_properties() -> Properties {

These are not needed since they are scoped to the file anyway and just create meaningless diffs between the files.
We should align them so rt-specific differences become immediately obvious by diffing the two chainspec files without getting added noise.
E.g. the snippet above should just be named properties instead of manta_properties

@ghzlatarev ghzlatarev added this to the Future milestone Jul 15, 2022
@Garandor Garandor modified the milestones: Future, v3.3.0 Jul 18, 2022
@Garandor Garandor added A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime A-runtime Area: Issues and PRs related to Runtimes A-dolphin Area: Issues and PRs related to the Dolphin Runtime labels Jul 18, 2022
@ghzlatarev ghzlatarev added the C-good-first-issue Category: Good first issues label Jul 18, 2022
@ghzlatarev ghzlatarev modified the milestones: v3.3.0, v3.4.0 Aug 5, 2022
@Garandor Garandor modified the milestones: v3.4.0, v3.5.0 Sep 9, 2022
@Garandor Garandor modified the milestones: v3.5.0, v3.6.0 Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime A-manta Area: Issues and PRs related to the Manta Runtime A-runtime Area: Issues and PRs related to Runtimes C-good-first-issue Category: Good first issues P-low Priority: Low
Projects
None yet
Development

No branches or pull requests

3 participants