Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a unit test to validate the comprehensive sample #1200

Closed
ghost opened this issue Jan 2, 2019 · 1 comment
Closed

Add a unit test to validate the comprehensive sample #1200

ghost opened this issue Jan 2, 2019 · 1 comment
Labels
area-test Issues for improving the tests and adding new ones. resolved-by-design

Comments

@ghost
Copy link

ghost commented Jan 2, 2019

No description provided.

@ghost ghost added enhancement area-test Issues for improving the tests and adding new ones. and removed enhancement labels Jan 2, 2019
@ghost ghost mentioned this issue Jan 2, 2019
Merged
@ghost
Copy link
Author

ghost commented Jan 2, 2019

We already have a test that validates all the test files. It does the prerelease compatibility transform first, which explains why the test passes but the sample file shows squiggles against the current schema.

@ghost ghost closed this as completed Jan 2, 2019
@ghost ghost added the resolved-by-design label Jan 2, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test Issues for improving the tests and adding new ones. resolved-by-design
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants