Skip to content
This repository has been archived by the owner on Oct 2, 2021. It is now read-only.

Add reasons for breakpoint bind failure #38

Closed
roblourens opened this issue Jun 8, 2016 · 2 comments
Closed

Add reasons for breakpoint bind failure #38

roblourens opened this issue Jun 8, 2016 · 2 comments
Labels
enhancement

Comments

@roblourens
Copy link
Member

P1, 2 days
It looks like the Node adapter can send back specific error messages when setBreakpoints fails.
@roblourens roblourens added this to the M1 milestone Jun 14, 2016
@roblourens roblourens mentioned this issue Jun 14, 2016
Closed
@roblourens roblourens removed this from the M1 milestone Jul 6, 2016
@roblourens roblourens mentioned this issue Jul 7, 2016
Closed
@weinand weinand mentioned this issue Aug 27, 2016
Closed
29 tasks
@roblourens roblourens mentioned this issue Aug 29, 2016
Closed
38 tasks
@roblourens
Copy link
Member Author

Don't hang on to BP requests if it can't bind. Return immediately, and when it binds later, send a BreakpointEvent. Also causes issues when BPs don't bind during 'configuration', but that will mostly be fixed by #47

@roblourens
Copy link
Member Author

Also, in case of having a sourcemap but the runtime script isn't loaded - the response from CDP isn't handled quite right in that case.

@roblourens roblourens mentioned this issue Sep 22, 2016
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@roblourens