Skip to content
This repository has been archived by the owner on Oct 2, 2021. It is now read-only.

Show getter property value #77

Closed
f111fei opened this issue Aug 2, 2016 · 5 comments
Closed

Show getter property value #77

f111fei opened this issue Aug 2, 2016 · 5 comments

Comments

@f111fei
Copy link

f111fei commented Aug 2, 2016

When I use chrome debugger, I find variables can't show the getter property value.

qq 20160729214752

related to microsoft/vscode#9949

@weinand
Copy link

weinand commented Aug 3, 2016

I see the following two options (which both do not require additional debug protocol):

  • auto resolve getters in the debug adapter (no UI gesture required),
  • make the "property" node expandable so that the resolve happens lazily with the "expand" UI gesture. This functionality is almost identical to PR Debug: Allow click to show getter property value vscode#9949 but it uses a UI metaphor that is already well known.

@roblourens
Copy link
Member

Andre, 2 is a good idea, I hadn't thought of that. But if nobody is complaining about the node adapter auto resolving them, I'll probably copy that behavior.

@f111fei
Copy link
Author

f111fei commented Aug 4, 2016

@weinand idea 2 may be hard to Implement. Because the "expand" UI gesture is only to get the node's children, can not change this node self.

@weinand
Copy link

weinand commented Aug 4, 2016

@f111fei the debug adapter is free to surface anything as a "child". So in case of a getter, the resolved value would become the child.

@f111fei
Copy link
Author

f111fei commented Aug 4, 2016

@weinand
If the getter result as getter property child, it make sense. Thanks for the answer.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants