Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor main.js #4313

Closed
mmmavis opened this issue Mar 7, 2020 · 1 comment
Closed

Refactor main.js #4313

mmmavis opened this issue Mar 7, 2020 · 1 comment
Assignees
@mmmavis
Labels
engineering frontend
Milestone
Apr 20

Comments

@mmmavis
Copy link
Collaborator

mmmavis commented Mar 7, 2020 •
edited
Loading

main.js has grown big and become hard to maintain. Let's refactor it.

Some ideas

  • Put event handlers in their own files (maybe also further separate global/document handlers from others?)
  • Many event handlers are env var independent and can/need to be bound before we hear back from fetchEnv

/cc @Pomax to drop in thoughts
@cadecairos cadecairos added this to the Mar 23 milestone Mar 10, 2020
@cadecairos cadecairos modified the milestones: Mar 23, Apr 6 Mar 24, 2020
This was referenced Mar 31, 2020
Merged
Merged
@cadecairos cadecairos modified the milestones: Apr 6, Apr 20 Apr 7, 2020
@mmmavis
Copy link
Collaborator Author

mmmavis commented Apr 17, 2020

Yay! This is done! I'll create another ticket for refactoring bg-main.js

@mmmavis mmmavis closed this as completed Apr 17, 2020
@mmmavis mmmavis mentioned this issue Apr 17, 2020
Closed
@data-sync-user data-sync-user mentioned this issue Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmmavis mmmavis

Labels
engineering frontend
Projects
None yet
Milestone
Apr 20
Development

No branches or pull requests
2 participants
@cadecairos @mmmavis