Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice: Upstream fixes to patch ffmpeg bugs #818

Open
gnif opened this issue Nov 26, 2023 · 1 comment
Open

Notice: Upstream fixes to patch ffmpeg bugs #818

gnif opened this issue Nov 26, 2023 · 1 comment

Comments

@gnif
Copy link

gnif commented Nov 26, 2023

The below hack should no longer be needed once the following patches to ffmpeg have been merged:

if (ctx->codec_id == AV_CODEC_ID_AC3)
ctx->ch_layout.nb_channels = m_audio->GetMaxChannels();

https://patchwork.ffmpeg.org/project/ffmpeg/patch/20231126043322.1681663-1-geoff@hostfission.com/
https://patchwork.ffmpeg.org/project/ffmpeg/patch/20231126050100.1686194-1-geoff@hostfission.com/

These patches fix the crashes caused by using downmix in codecs, you should not need to use a whitelist (DecoderWillDownmix) anymore.

@gnif
Copy link
Author

gnif commented Nov 26, 2023

These patches have been merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant