Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] support collect aggregations #2062

Closed
21 tasks done
sperlingxx opened this issue Apr 1, 2021 · 3 comments
Closed
21 tasks done

[FEA] support collect aggregations #2062

sperlingxx opened this issue Apr 1, 2021 · 3 comments
Assignees
@sperlingxx
Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf epic Issue that encompasses a significant feature or body of work feature request New feature or request
Milestone
Apr 4 - Apr 15

Comments

@sperlingxx
Copy link
Collaborator

sperlingxx commented Apr 1, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.
This is an umbrella issue for the support work of collect aggregations.
@sperlingxx sperlingxx added feature request New feature or request ? - Needs Triage Need team to review and classify labels Apr 1, 2021
@sperlingxx sperlingxx self-assigned this Apr 1, 2021
@sameerz sameerz added cudf_dependency An issue or PR with this label depends on a new feature in cudf epic Issue that encompasses a significant feature or body of work and removed ? - Needs Triage Need team to review and classify labels Apr 4, 2021
@mythrocks
Copy link
Collaborator

Hello, @sperlingxx. I didn't realize at the time that you'd picked up rapidsai/cudf#7809. It would be best to postpone this until the rolling-window dispatch logic is reworked.

The tests you've written are good: comprehensive and reusable. The implementation will likely have changes, after the dispatch redesign. My apologies for not having caught this before you began work on this.

This was referenced Jun 7, 2021
Closed
Closed
@sameerz sameerz mentioned this issue Jul 16, 2021
Closed
@sperlingxx
Copy link
Collaborator Author

The plugin support of groupBy context is 75% done, because 3 out of 4 sub-tasks are done. The remaining unfinished(WIP) task is nice to have, since we introduced a feature in task 3 which falls back all stages of Aggregate to CPU associately in case of unexpected crashes.

@sperlingxx sperlingxx mentioned this issue Mar 21, 2022
Merged
@sameerz sameerz added this to the Mar 21 - Apr 1 milestone Mar 22, 2022
@sameerz sameerz modified the milestones: Mar 21 - Apr 1, Apr 4 - Apr 15 Apr 4, 2022
@sperlingxx
Copy link
Collaborator Author

Close this issue since all sub tasks under these issue are cleaned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sperlingxx sperlingxx

Labels
cudf_dependency An issue or PR with this label depends on a new feature in cudf epic Issue that encompasses a significant feature or body of work feature request New feature or request
Projects
None yet
Milestone
Apr 4 - Apr 15
Development

No branches or pull requests
3 participants
@mythrocks @sperlingxx @sameerz