Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dendrogram not reordering cell types in plot #88

Closed
Al-Murphy opened this issue Oct 31, 2023 · 1 comment
Closed

Dendrogram not reordering cell types in plot #88

Al-Murphy opened this issue Oct 31, 2023 · 1 comment
Assignees
Labels

Comments

@Al-Murphy
Copy link
Collaborator

Al-Murphy commented Oct 31, 2023

1. Bug description

When ewce_plot() is run with make_dendro = TRUE, the resulting column order in the $withDendro output plot is the same as the plain plot meaning there is no update to the cell type orders based on the dendrogram. It is unclear if this has always been the case or is a bug introduced by the refactoring.

Adding a fix and a unit test for this now and will push to both the release and dev branch.

@Al-Murphy Al-Murphy added the bug label Oct 31, 2023
@Al-Murphy Al-Murphy self-assigned this Oct 31, 2023
@Al-Murphy
Copy link
Collaborator Author

The issue only affected cases where there was no plotting values in the ctd i.e. no value in ctd[[annot_level]]$plotting.

Fix implemented in v1.11.1 and release v1.10.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant