jiracli.findClosestParentPath is broken with figtree v1.0.0 #277
Comments
mikepea
added a commit
that referenced
this issue
Sep 16, 2019
... largely to confirm behaviour of underlying figtree function, and to highlight when we're pulling the old figtree and hence breaking the build No idea why a regular compile isn't picking this up - but when explicitly testing like this, we get the error detailed in #277: ``` Mikes-MBP:jira mike$ go test ./... ? github.com/go-jira/jira [no test files] jiracli/util.go:29:34: too many arguments in call to figtree.FindParentPaths have (string, string, string) want (string) jiracli/util.go:29:34: too many arguments in call to figtree.FindParentPaths have (string, string, string) want (string) FAIL github.com/go-jira/jira/jiracli [build failed] ok github.com/go-jira/jira/jiradata (cached) Mikes-MBP:jira mike$ ```
mikepea
added a commit
that referenced
this issue
Sep 16, 2019
Ran `go get -u github.com/coryb/figtree@master` Tests now pass
mikepea
changed the title
mikepea
added a commit
that referenced
this issue
Sep 16, 2019
I inadvertently 'upgraded' to coryb/figtree v1.0.0, and it caused an error in findCLosestParentPath, due to figtree.FindParentPaths having a different function signature in v1.0.0 No idea why a regular compile isn't picking this up - but when explicitly testing like this, we get the error detailed in #277: ``` Mikes-MBP:jira mike$ go test ./... ? github.com/go-jira/jira [no test files] jiracli/util.go:29:34: too many arguments in call to figtree.FindParentPaths have (string, string, string) want (string) jiracli/util.go:29:34: too many arguments in call to figtree.FindParentPaths have (string, string, string) want (string) FAIL github.com/go-jira/jira/jiracli [build failed] ok github.com/go-jira/jira/jiradata (cached) Mikes-MBP:jira mike$ ```
coryb
added a commit
that referenced
this issue
Sep 16, 2019
|
fixed in #278 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Somehow I managed to update the go.mod to use coryb/figtree v1.0.0 -- I think this happened kinda naturally, since the current specified version is pinned to v0.0.0-{commit}.
There's a difference in the function signature, that results in an error:
The text was updated successfully, but these errors were encountered: