Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trailing whitespace to JSON file #44

Open
kellenff opened this issue Aug 9, 2020 · 1 comment
Open

Add trailing whitespace to JSON file #44

kellenff opened this issue Aug 9, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@kellenff
Copy link

kellenff commented Aug 9, 2020

Is your feature request related to a problem? Please describe.
I run a standard pre-commit lint which checks for a trailing newline in all files. When the .pytest-queries file is updated the trailing newline is stripped and must be manually added afterwards

Describe the solution you'd like
Appending a trailing newline to the output

Describe alternatives you've considered
Files can be excluded from the lint, but I'd prefer to avoid special-casing where possible

Additional context
The lint which flags this file is recommended by the pre-commit project, so will probably affect a fair number of users

@NyanKiyoshi
Copy link
Owner

NyanKiyoshi commented Aug 9, 2020

Hi,

This is a fair point. I noticed you have created a branch for it on a fork, you could open a PR. Tests are failing to which I see why, I will fix them whenever I am available for it as they are not related to your changes. Once the tests are fixed I will ping you to rebase your branch.

Meantime, you can use a exclude in your pre-commit file as a temporary work-around.

@NyanKiyoshi NyanKiyoshi added the enhancement New feature or request label Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants