From 89b2e472639522132f60ae6520c7dbf7cec94421 Mon Sep 17 00:00:00 2001
From: rmroot <rootrm@ornl.gov>
Date: Thu, 15 Feb 2024 15:13:24 -0600
Subject: [PATCH] fixes to mobile emissions conversions in calanderization

---
 .../calanderization/calanderizationHelpers.ts  |  2 +-
 .../calanderization/calanderizeMeters.ts       | 18 ++++++------------
 .../conversions/convertMeterData.ts            | 10 ++++++++--
 .../calanderization.component.html             |  2 +-
 .../calanderization.component.ts               |  6 ++++++
 ...alanderized-meter-data-table.component.html |  2 +-
 .../calanderized-meter-data-table.component.ts |  2 ++
 .../vehicle-data-table.component.html          |  2 +-
 .../vehicle-data-table.component.ts            |  6 ++++++
 9 files changed, 32 insertions(+), 18 deletions(-)

diff --git a/src/app/calculations/calanderization/calanderizationHelpers.ts b/src/app/calculations/calanderization/calanderizationHelpers.ts
index b511ea003..31e8808a9 100644
--- a/src/app/calculations/calanderization/calanderizationHelpers.ts
+++ b/src/app/calculations/calanderization/calanderizationHelpers.ts
@@ -62,7 +62,7 @@ export function getConsumptionUnit(meter: IdbUtilityMeter, accountOrFacility: Id
 }
 
 export function getUnitFromMeter(accountMeter: IdbUtilityMeter, accountOrFacility: IdbAccount | IdbFacility): string {
-    if (accountMeter.source == 'Electricity' || getIsEnergyUnit(accountMeter.startingUnit)) {
+    if (accountMeter.source == 'Electricity' || (getIsEnergyUnit(accountMeter.startingUnit) && accountMeter.scope != 2)) {
         return accountOrFacility.energyUnit;
     } else if (accountMeter.source == 'Natural Gas') {
         return accountOrFacility.volumeGasUnit;
diff --git a/src/app/calculations/calanderization/calanderizeMeters.ts b/src/app/calculations/calanderization/calanderizeMeters.ts
index 6af7d530e..9a3865fe7 100644
--- a/src/app/calculations/calanderization/calanderizeMeters.ts
+++ b/src/app/calculations/calanderization/calanderizeMeters.ts
@@ -311,12 +311,6 @@ function getBillPeriodTotal(previousReading: IdbUtilityMeterData, currentReading
         meter.vehicleDistanceUnit,
         hhvOrFuelEfficiencyCurrent);
 
-    if (isNaN(emissionsForCurrent.mobileCarbonEmissions)) {
-        console.log(currentReading);
-        console.log(meter);
-        console.log('===')
-    }
-
     let costForCurrent: number = (currentReading.totalCost / daysFromPrevious) * daysFromCurrent;
 
     //days from next bill to current bill reading
@@ -410,7 +404,7 @@ function calanderizeMeterDataFullMonth(meter: IdbUtilityMeter, meterData: Array<
             let readingSummaries: Array<CalanderizedReadingSummary> = new Array();
             currentMonthsReadings.forEach(reading => {
                 let totalMonthEnergyUse: number = 0;
-                let totalMonthEnergyConsumption: number = 0;
+                let totalConsumption: number = 0;
                 let totalMonthCost: number = Number(reading.totalCost);
                 //energy use
                 let isEnergyMeter: boolean = getIsEnergyMeter(meter.source);
@@ -419,10 +413,10 @@ function calanderizeMeterDataFullMonth(meter: IdbUtilityMeter, meterData: Array<
                 }
                 //energy consumption (data input not as energy)
                 let isEnergyUnit: boolean = getIsEnergyUnit(meter.startingUnit);
-                if (!isEnergyUnit) {
-                    totalMonthEnergyConsumption = Number(reading.totalVolume);
+                if (!isEnergyUnit || meter.scope == 2) {
+                    totalConsumption = Number(reading.totalVolume);
                 } else {
-                    totalMonthEnergyConsumption = totalMonthEnergyUse;
+                    totalConsumption = totalMonthEnergyUse;
                 }
                 let hhvOrFuelEfficiency: number = reading.heatCapacity;
                 if (meter.scope == 2) {
@@ -433,12 +427,12 @@ function calanderizeMeterDataFullMonth(meter: IdbUtilityMeter, meterData: Array<
                     facilities,
                     co2Emissions,
                     customFuels,
-                    totalMonthEnergyConsumption,
+                    totalConsumption,
                     meter.vehicleCollectionUnit,
                     meter.vehicleDistanceUnit,
                     hhvOrFuelEfficiency);
                 readingSummaries.push({
-                    consumption: totalMonthEnergyConsumption,
+                    consumption: totalConsumption,
                     energyUse: totalMonthEnergyUse,
                     cost: totalMonthCost,
                     emissionsResults: emissions,
diff --git a/src/app/calculations/conversions/convertMeterData.ts b/src/app/calculations/conversions/convertMeterData.ts
index 490970ae7..f01313ee4 100644
--- a/src/app/calculations/conversions/convertMeterData.ts
+++ b/src/app/calculations/conversions/convertMeterData.ts
@@ -32,8 +32,14 @@ export function convertMeterData(meter: IdbUtilityMeter, meterData: Array<IdbUti
         if (meter.source == 'Other Fuels' && meter.scope == 2) {
             startingUnit = meter.vehicleCollectionUnit;
         }
-        for (let index: number = 0; index < copyMeterData.length; index++) {
-            copyMeterData[index].totalVolume = new ConvertValue(copyMeterData[index].totalVolume, startingUnit, facilityUnit).convertedValue;
+        if (meter.scope != 2) {
+            for (let index: number = 0; index < copyMeterData.length; index++) {
+                copyMeterData[index].totalVolume = new ConvertValue(copyMeterData[index].totalVolume, startingUnit, facilityUnit).convertedValue;
+            }
+        } else if (meter.vehicleCollectionType == 1) {
+            for (let index: number = 0; index < copyMeterData.length; index++) {
+                copyMeterData[index].totalVolume = new ConvertValue(copyMeterData[index].totalVolume, startingUnit, facilityUnit).convertedValue;
+            }
         }
     }
     return copyMeterData;
diff --git a/src/app/facility/utility-data/calanderization/calanderization.component.html b/src/app/facility/utility-data/calanderization/calanderization.component.html
index 02e37c630..76fd6985e 100644
--- a/src/app/facility/utility-data/calanderization/calanderization.component.html
+++ b/src/app/facility/utility-data/calanderization/calanderization.component.html
@@ -117,7 +117,7 @@ <h4>{{selectedMeter.name}} Calanderized Data
 
                 <div>
                     <app-calanderized-meter-data-table *ngIf="dataDisplay == 'table'" [itemsPerPage]="itemsPerPage"
-                        [calanderizedMeter]="calanderizedMeter">
+                            [calanderizedMeter]="calanderizedMeter" [consumptionLabel]="consumptionLabel">
                     </app-calanderized-meter-data-table>
                     <app-calanderization-chart *ngIf="dataDisplay == 'graph'" [meterData]="calanderizedMeter"
                         [displayGraphEnergy]="displayGraphEnergy" [displayGraphCost]="displayGraphCost">
diff --git a/src/app/facility/utility-data/calanderization/calanderization.component.ts b/src/app/facility/utility-data/calanderization/calanderization.component.ts
index d1af94746..ac7eb9183 100644
--- a/src/app/facility/utility-data/calanderization/calanderization.component.ts
+++ b/src/app/facility/utility-data/calanderization/calanderization.component.ts
@@ -43,6 +43,7 @@ export class CalanderizationComponent implements OnInit {
   selectedFacility: IdbFacility;
   displayDataApplicationModal: boolean = false;
   hasMeterData: boolean;
+  consumptionLabel: 'Consumption' | 'Distance';
   constructor(private calanderizationService: CalanderizationService, private utilityMeterDbService: UtilityMeterdbService,
     private facilityDbService: FacilitydbService,
     private dbChangesService: DbChangesService, private accountDbService: AccountdbService,
@@ -107,6 +108,11 @@ export class CalanderizationComponent implements OnInit {
       let calanderizedMeterData: Array<CalanderizedMeter> = getCalanderizedMeterData([this.selectedMeter], facilityMeterData, this.selectedFacility, false, undefined, this.eGridService.co2Emissions, customFuels, [this.selectedFacility]);
       calanderizedMeterData = this.filterMeterDataDateRanges(calanderizedMeterData);
       this.calanderizedMeter = calanderizedMeterData[0];
+      if(this.selectedMeter.scope != 2){
+        this.consumptionLabel = 'Consumption';
+      }else{
+        this.consumptionLabel = 'Distance';
+      }
     }
   }
 
diff --git a/src/app/facility/utility-data/calanderization/calanderized-meter-data-table/calanderized-meter-data-table.component.html b/src/app/facility/utility-data/calanderization/calanderized-meter-data-table/calanderized-meter-data-table.component.html
index 317b1b39b..84bd29fe4 100644
--- a/src/app/facility/utility-data/calanderization/calanderized-meter-data-table/calanderized-meter-data-table.component.html
+++ b/src/app/facility/utility-data/calanderization/calanderized-meter-data-table/calanderized-meter-data-table.component.html
@@ -11,7 +11,7 @@
                 Month</th>
             <th (click)="setOrderDataField('energyConsumption')"
                 [ngClass]="{'active': orderDataField == 'energyConsumption'}" *ngIf="calanderizedMeter.showConsumption">
-                Total Consumption<br> (<span [innerHTML]="calanderizedMeter.consumptionUnit | settingsLabel"></span>)
+                Total {{consumptionLabel}}<br> (<span [innerHTML]="calanderizedMeter.consumptionUnit | settingsLabel"></span>)
             </th>
             <th (click)="setOrderDataField('energyUse')" [ngClass]="{'active': orderDataField == 'energyUse'}"
                 *ngIf="calanderizedMeter.showEnergyUse">
diff --git a/src/app/facility/utility-data/calanderization/calanderized-meter-data-table/calanderized-meter-data-table.component.ts b/src/app/facility/utility-data/calanderization/calanderized-meter-data-table/calanderized-meter-data-table.component.ts
index 68fa654f2..8c8dfcd47 100644
--- a/src/app/facility/utility-data/calanderization/calanderized-meter-data-table/calanderized-meter-data-table.component.ts
+++ b/src/app/facility/utility-data/calanderization/calanderized-meter-data-table/calanderized-meter-data-table.component.ts
@@ -12,6 +12,8 @@ export class CalanderizedMeterDataTableComponent implements OnInit {
   calanderizedMeter: CalanderizedMeter;
   @Input()
   itemsPerPage: number;
+  @Input()
+  consumptionLabel: 'Consumption' | 'Distance';
 
   @ViewChild('meterDataTable', { static: false }) meterDataTable: ElementRef;
   orderDataField: string = 'date';
diff --git a/src/app/facility/utility-data/energy-consumption/utility-meter-data/utility-meter-data-table/vehicle-data-table/vehicle-data-table.component.html b/src/app/facility/utility-data/energy-consumption/utility-meter-data/utility-meter-data-table/vehicle-data-table/vehicle-data-table.component.html
index ab79d0976..5d15acd72 100644
--- a/src/app/facility/utility-data/energy-consumption/utility-meter-data/utility-meter-data-table/vehicle-data-table/vehicle-data-table.component.html
+++ b/src/app/facility/utility-data/energy-consumption/utility-meter-data/utility-meter-data-table/vehicle-data-table/vehicle-data-table.component.html
@@ -23,7 +23,7 @@
             <th (click)="setOrderDataField('readDate')" [ngClass]="{'active': orderDataField == 'readDate'}"
                 class="row-year">Meter Read Date</th>
             <th (click)="setOrderDataField('totalVolume')" [ngClass]="{'active': orderDataField == 'totalVolume'}">
-                Total Consumption<br> (<span [innerHTML]="volumeUnit | settingsLabel"></span>)
+                Total {{consumptionLabel}}<br> (<span [innerHTML]="volumeUnit | settingsLabel"></span>)
             </th>
             <th (click)="setOrderDataField('totalEnergyUse')" [ngClass]="{'active': orderDataField == 'totalEnergyUse'}"
                 *ngIf="vehicleDataFilters.totalEnergy">Total Energy<br> (<span [innerHTML]="energyUnit | settingsLabel"></span>)</th>
diff --git a/src/app/facility/utility-data/energy-consumption/utility-meter-data/utility-meter-data-table/vehicle-data-table/vehicle-data-table.component.ts b/src/app/facility/utility-data/energy-consumption/utility-meter-data/utility-meter-data-table/vehicle-data-table/vehicle-data-table.component.ts
index 12c595d2e..202be0585 100644
--- a/src/app/facility/utility-data/energy-consumption/utility-meter-data/utility-meter-data-table/vehicle-data-table/vehicle-data-table.component.ts
+++ b/src/app/facility/utility-data/energy-consumption/utility-meter-data/utility-meter-data-table/vehicle-data-table/vehicle-data-table.component.ts
@@ -46,6 +46,7 @@ export class VehicleDataTableComponent {
   showDetailedCharges: boolean;
   volumeUnit: string;
   energyUnit: string
+  consumptionLabel: 'Consumption' | 'Distance';
   constructor(private utilityMeterDataService: UtilityMeterDataService,
     private copyTableService: CopyTableService,
     private customFuelDbService: CustomFuelDbService,
@@ -72,6 +73,11 @@ export class VehicleDataTableComponent {
 
   ngOnChanges() {
     this.setData();
+    if(this.selectedMeter.scope != 2){
+      this.consumptionLabel = 'Consumption';
+    }else{
+      this.consumptionLabel = 'Distance';
+    }
   }
 
   setData() {