Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor modals #65

Closed
5 tasks
tcp opened this issue Mar 21, 2021 · 0 comments
Closed
5 tasks

Refactor modals #65

tcp opened this issue Mar 21, 2021 · 0 comments
Assignees
@tcp
Labels
Status: In Progress 🌟 This is actively being worked on Type: Refactor 🔨 A complete overhaul of a file, feature, or codebase
Milestone
v0.5.0

Comments

@tcp
Copy link
Collaborator

tcp commented Mar 21, 2021 •
edited
Loading

What?

Remove all specialized modals and generalize.

Why?

It is cumbersome to use modals and it does not scale that well. Let's
make it easier to maintain.

Breakdown

  • Remove components/modals
    • Collocate each modal
    • Use @reach/dialog or a single modal component
    • Use the side panel in some views
    • Delete dead code
@tcp tcp added the Type: Refactor 🔨 A complete overhaul of a file, feature, or codebase label Mar 21, 2021
@tcp tcp self-assigned this Mar 21, 2021
@tcp tcp added the Status: In Progress 🌟 This is actively being worked on label Mar 21, 2021
@tcp tcp added this to the v1.0.0 milestone Mar 21, 2021
@tcp tcp closed this as completed in 39254b7 Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcp tcp

Labels
Status: In Progress 🌟 This is actively being worked on Type: Refactor 🔨 A complete overhaul of a file, feature, or codebase
Projects
None yet
Milestone
v0.5.0
Development

No branches or pull requests
1 participant
@tcp