Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method to show the meaning of the Air Quality Data #17

Closed
ubongab opened this issue Feb 24, 2022 · 7 comments · Fixed by #20
Closed

Add a method to show the meaning of the Air Quality Data #17

ubongab opened this issue Feb 24, 2022 · 7 comments · Fixed by #20
Assignees
Labels
beginner Slightly more complex than 'good first issue', but not difficult either enhancement New feature or request

Comments

@ubongab
Copy link
Contributor

ubongab commented Feb 24, 2022

For example, an aqi of 0 - 50 is Good and that means that _air quality is considered satisfactory, and air pollution poses little or no risk.

@Milind220
Copy link
Collaborator

@ubongab Yes, sounds like a great idea.

  • Can you try to add this as another column in the dataframe that is returned? Like a column which contains the AQI_meaning maybe.
  • Also, refer to the table of meanings for the AQI given in this API documentation page: https://aqicn.org/api/ . I think the 'meaning' column is enough, but feel free to add others too.

@Milind220
Copy link
Collaborator

That's the page for the API that is used under the hood to fetch the data.

@Milind220 Milind220 added beginner Slightly more complex than 'good first issue', but not difficult either enhancement New feature or request labels Feb 25, 2022
@ubongab
Copy link
Contributor Author

ubongab commented Feb 25, 2022

Ok, cool. I'll work on this.
One more question.
Would you prefer to see AQI_meaning [Good, moderate....] only or would it be better to include the health implications column as well, to make it more readable and understandable for any simple person requesting the data.
OR better still, shall I condense the two information into one column - AQI_meaning? That seems like a robust solution, I presume.

@Milind220
Copy link
Collaborator

Milind220 commented Feb 25, 2022

@ubongab
I think include both - more information is a good thing here.
It's probably best to leave the two as separate columns. Utility wise, it might give people more flexibility with what they want to use and what they don't care about.

@ubongab
Copy link
Contributor Author

ubongab commented Feb 25, 2022

Alright, that makes sense!

@ubongab
Copy link
Contributor Author

ubongab commented Feb 25, 2022

All done now. PR created.
Could you please check and if there is anything else that needs changing, please let me know. It's been a pleasure working on this.

@Milind220
Copy link
Collaborator

@ubongab Checked it out and merged it. Looks like just what we needed! Thanks for all the effort, it's much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner Slightly more complex than 'good first issue', but not difficult either enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants