Skip to content

Commit

Permalink
Add supybot.utils.net.getAddressFromHostname() and improve Socket dri…
Browse files Browse the repository at this point in the history
…ver to try successively all IP addresses.
  • Loading branch information
progval committed May 31, 2013
1 parent 9ea1019 commit 2016983
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
8 changes: 6 additions & 2 deletions src/drivers/Socket.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ def __init__(self, irc):
drivers.IrcDriver.__init__(self, irc)
drivers.ServersMixin.__init__(self, irc)
self.conn = None
self._attempt = -1
self.servers = ()
self.eagains = 0
self.inbuffer = b''
Expand Down Expand Up @@ -239,6 +240,7 @@ def connect(self, **kwargs):
self.reconnect(reset=False, **kwargs)

def reconnect(self, reset=True):
self._attempt += 1
self.nextReconnectTime = None
if self.connected:
drivers.log.reconnect(self.irc.network)
Expand All @@ -256,6 +258,8 @@ def reconnect(self, reset=True):
else:
drivers.log.debug('Not resetting %s.', self.irc)
server = self._getNextServer()
address = utils.net.getAddressFromHostname(server[0],
attempt=self._attempt)
drivers.log.connect(self.currentServer)
try:
socks_proxy = getattr(conf.supybot.networks, self.irc.network) \
Expand All @@ -267,7 +271,7 @@ def reconnect(self, reset=True):
log.error('Cannot use socks proxy (SocksiPy not installed), '
'using direct connection instead.')
socks_proxy = ''
self.conn = utils.net.getSocket(server[0], socks_proxy)
self.conn = utils.net.getSocket(address, socks_proxy)
vhost = conf.supybot.protocols.irc.vhost()
self.conn.bind((vhost, 0))
except socket.error, e:
Expand All @@ -281,7 +285,7 @@ def reconnect(self, reset=True):
if getattr(conf.supybot.networks, self.irc.network).ssl():
assert globals().has_key('ssl')
self.conn = ssl.wrap_socket(self.conn)
self.conn.connect(server)
self.conn.connect((address, server[1]))
def setTimeout():
self.conn.settimeout(conf.supybot.drivers.poll())
conf.supybot.drivers.poll.addCallback(setTimeout)
Expand Down
8 changes: 8 additions & 0 deletions src/utils/net.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,14 @@ def match(self, addr):
return count >= 1
emailRe = EmailRe()

def getAddressFromHostname(host, attempt=0):
addrinfo = socket.getaddrinfo(host, None)
addresses = []
for (family, socktype, proto, canonname, sockaddr) in addrinfo:
if sockaddr[0] not in addresses:
addresses.append(sockaddr[0])
return addresses[attempt % len(addresses)]

def getSocket(host, socks_proxy=None):
"""Returns a socket of the correct AF_INET type (v4 or v6) in order to
communicate with host.
Expand Down

0 comments on commit 2016983

Please sign in to comment.