-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to skip operations for RestoreLabeld Transform #8125
base: dev
Are you sure you want to change the base?
Conversation
Signed-off-by: Hsin Tong <zcc22592590@gmail.com>
for more information, see https://pre-commit.ci
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: Hsin-Tong Hsieh <75067139+ctongh@users.noreply.github.com>
Co-authored-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com> Signed-off-by: Hsin-Tong Hsieh <75067139+ctongh@users.noreply.github.com>
Signed-off-by: Hsin-Tong Hsieh <75067139+ctongh@users.noreply.github.com>
Hi @ericspod , Thanks for the suggestion. I've fixed the suggestions mentioned above, and I've also standardized the parameter names to |
Signed-off-by: Hsin Tong <zcc22592590@gmail.com>
Signed-off-by: Hsin Tong <zcc22592590@gmail.com>
"restore_resizing": False, | ||
"restore_cropping": False, | ||
"restore_spacing": False, | ||
"restore_slicing": False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have this test for when all the flags are false and the previous one where only one flag is false, I think we need the other three tests for when one flag at a time is false. This just ensures any future changes doesn't impact behaviour, the tests can be simple like this one if that's easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, after you help add these tests, I can help trigger more tests, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some minor test-related suggestions but otherwise I think this is fine. I will ask @KumoLiu to review and enable blossom as well. Thanks!
Fixes #6380
Description
Four new bool parameters are added into
RestoreLabeld
to allow users to selectively enable or disable each restoration operation as needed, and a corresponding test case is added to verify that the function runs correctly.This design allows users to selectively enable or disable each restoration operation as needed, providing greater flexibility.
Types of changes
./runtests.sh -f -u --net --coverage
../runtests.sh --quick --unittests --disttests
.make html
command in thedocs/
folder.