Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantics #60

Closed
2 tasks done
Tracked by #54
smeragoel opened this issue Feb 7, 2024 · 3 comments
Closed
2 tasks done
Tracked by #54

Semantics #60

smeragoel opened this issue Feb 7, 2024 · 3 comments

Comments

@smeragoel
Copy link

smeragoel commented Feb 7, 2024

🌐 CSS Content

Meaningful content must not be implemented using only CSS :before or :after - WCAG 1.3.1

  • With CSS Styles disabled, the Example Gallery and "Supports PyData and Jupyter" links are not accessible.
    Before:
    image
    After disabling CSS Styles:
    image
    image

  • When activating the visual helper for the accessibility test, unexpected "lines" appear on the screen.
    image
    image

@gabalafou
Copy link
Contributor

First issue is fixed, see pydata/pydata-sphinx-theme#1549 (comment)

@gabalafou
Copy link
Contributor

As for the second issue, the red lines are highlighting all of the pseudo-elements for the that admonition, of which there are three:

  1. .admonition::after { content: "" } - I'm not exactly sure what purpose this pseudo-element serves, it's probably some kind of layout fix, but as its content is an empty string, it contains no meaningful content, so it's not an issue.
  2. .admonition-title::before { content: "" } - This puts a green bar behind the title, again no content, so not an issue
  3. .admonition-title::after { content: var(--pst-icon-admonition-seealso) } - This is the share icon. It is set to --pst-icon-share: "\f064";. It is purely decorative. The meaning of the icon is conveyed by the admonition title text, which is "See also." So this one is also not an issue. The pseudo-element content appears in the accessibility tree, which is probably less than ideal, but it was ignored by VoiceOver when I tested it. So I don't think this is an issue.

@gabalafou
Copy link
Contributor

Given my previous comment, I going to check off the second checkbox and close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants