Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sane default for delete-other #23

Closed
LeroyR opened this issue May 7, 2019 · 3 comments
Closed

Sane default for delete-other #23

LeroyR opened this issue May 7, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@LeroyR
Copy link

LeroyR commented May 7, 2019

Either default delete-other-pattern to <distribution-name>$ or introduce a new config value for cleaning up removed projects.

Is your feature request related to a problem? Please describe.
I argue that the default workflow while creating/using dists is (re)generation of jenkins jobs including removing jobs with --delete-other --delete-other-pattern <dist>$

This also prevents accidental removal of all other jobs in jenkins instances that build multiple generations if the pattern is left on default during invocation with --delete-other

@LeroyR LeroyR added the enhancement New feature or request label May 7, 2019
@scymtym
Copy link
Member

scymtym commented May 7, 2019

I will commit an improvement for this.

Just to be clear, though:

introduce a new config value for cleaning up removed projects.

Is this referring to the file- and environment-variable-based configuration? If so, this is already the case. The option is called commands.generate.delete-other-pattern. It can be set in a configuration file like this:

[commands.generate]
delete-other-pattern = my-suffix$

@LeroyR
Copy link
Author

LeroyR commented May 8, 2019

This only matters if distributions are generated "alone" while there are multiple on the target jenkins.
In this case it is not possible to have a fixed configured pattern as it depends on the used distribution

@scymtym
Copy link
Member

scymtym commented May 8, 2019

This only matters if distributions are generated "alone" while there are multiple on the target jenkins. In this case it is not possible to have a fixed configured pattern as it depends on the used distribution

Sure, that's why I said I will commit an improvement for this irregardless of the configuration aspect.

@scymtym scymtym closed this as completed in b86e488 May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants