Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JOSS Review] Automated tests: some automated tests fail #89

Closed
davidegraff opened this issue May 23, 2022 · 1 comment · Fixed by #90
Closed

[JOSS Review] Automated tests: some automated tests fail #89

davidegraff opened this issue May 23, 2022 · 1 comment · Fixed by #90

Comments

@davidegraff
Copy link

davidegraff commented May 23, 2022 •
edited
Loading

cc openjournals/joss-reviews#4337

After setting up the riassigner-dev environment and installing RIAssigner according to the instructions in the README, I ran:

$ pytest > pytest.log

and some of the tests failed. I have attached the output here: pytest.log
@davidegraff davidegraff changed the title [JOSS Review] some automated tests fail [JOSS Review] Automated tests: some automated tests fail May 23, 2022
@hechth hechth mentioned this issue May 26, 2022
Merged
@hechth
Copy link
Member

hechth commented May 26, 2022

@davidegraff please check out the PR #90 - this should solve those issues.

Please feel free to comment here or on the PR! Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated matchms dependency and removed test cases with None retention times hechth/RIAssigner
2 participants
@hechth @davidegraff