[HIP Package] HIP version from cmake is unreliable

[junliume]

HIP currently uses GITDATE to cmake package version and not using PATCH version. The following is not reporting correct version as reported by hipcc --version

find_package(hip REQUIRED PATHS /opt/rocm)
message(STATUS "Build with HIP ${hip_VERSION}")

Until this issue is resolved, MIOpen needs to work around to incremental and backward-incompatible hipRTC changes.

Mentioned:

• [HotFix] Adapt to changes to HIPRTC in current Staging/Mainline (future 6.1 RC) that disallow the use of <limits> in kernels #2650 (review)
• https://github.com/ROCm/MIOpen/pull/2637/files

Keep track of code changes necessary when the exact version is fixed:

• \todo: exact version from which this WA is needed should be updated in release
• src/kernels/miopen_cstdint.hpp
• src/kernels/miopen_type_traits.hpp
• src/comgr.cpp
• test/handle_test.cpp

[junliume]

@atamazov now the mainline HIP version for minor version is fixed, so the cmake should identify the HIP package version correctly to 6.1. However, the patch version is still not fixed thus not reliable.

Could we modify on top of merged #2644 and #2652, and eliminate the requirement of forced HIP version in cmake? Thanks!

update:
I guess this line would be challenging ...

MIOpen/src/kernels/miopen_type_traits.hpp

Line 79 in 0fab579

#if HIP_PACKAGE_VERSION_FLAT >= 6001000000ULL && HIP_PACKAGE_VERSION_FLAT < 6001024000ULL

[atamazov]

@junliume

Could we modify on top of merged #2644 and #2652, and eliminate the requirement of forced HIP version in cmake?

We do not need to modify anything in MIOpen. If minor version is fixed, then we simply do not need to provide CMake with -DMIOPEN_OVERRIDE_HIP_VERSION_MINOR=... when we build the library.

[atamazov]

@junliume

update: I guess this line would be challenging ...

MIOpen/src/kernels/miopen_type_traits.hpp

Line 79 in 0fab579

#if HIP_PACKAGE_VERSION_FLAT >= 6001000000ULL && HIP_PACKAGE_VERSION_FLAT < 6001024000ULL

If you mean #2652 (comment), then please do not worry, I'll prepare the fix.

[junliume]

@junliume

update: I guess this line would be challenging ...

MIOpen/src/kernels/miopen_type_traits.hpp

Line 79 in 0fab579

#if HIP_PACKAGE_VERSION_FLAT >= 6001000000ULL && HIP_PACKAGE_VERSION_FLAT < 6001024000ULL

If you mean #2652 (comment), then please do not worry, I'll prepare the fix.

@atamazov in this case, do we still need to provide to cmake command with -DMIOPEN_OVERRIDE_HIP_VERSION_PATCH=24000? The patch version is still not reliable at the moment.

[atamazov]

@junliume It depends on HIP version reported by future HIP staging, mainline and releases. And also on possible future functional changes in HIP that could enforce us to make more changes in the library.

But overriding could be allowed for staging and mainline HIP only. The adaptations must ensure that library works correctly out of the box with with all HIP releases, -- that is the implied goal.

[atamazov]

Some changes in the patch version provided by HIP: #2764 (comment)