Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLIR] Sort out the problem with StridedMemRef #862

Open
atamazov opened this issue Apr 17, 2021 · 4 comments
Open

[MLIR] Sort out the problem with StridedMemRef #862

atamazov opened this issue Apr 17, 2021 · 4 comments

Comments

@atamazov
Copy link
Contributor

Please do that when first round of fwd/bwd/wrw done.

@jerryyin
Copy link
Member

@jerryyin
Copy link
Member

Short term solution on exposing a structure from the Miir.h interface has been implemented and merged

Regarding on the long term solution, me && @atamazov synced offline and agreed that the short term solution is:

  • Simple
  • Good for speed

The solution does not has any apparent flaws for existing use cases. Therefore, I'm setting this ticket as low priority. We will implement any fix necessary when any of the below happened:

  • libMLIRMIOpen get more matured with its interface overall, and we find it necessary to expose a different set of information from the interface
  • The short term solution cannot satisfy all use case
  • We have a breaking change in the runtime and structure flattening get dropped

@ppanchad-amd
Copy link

@atamazov @jerryyin Is there still plan to implement the long term solution? If not, can we close this ticket? Thanks!

@atamazov
Copy link
Contributor Author

@jerryyin Yep, maybe it's time to revise this ticket. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants