Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MI300] add CI test stages #2396
[MI300] add CI test stages #2396
Changes from all commits
b3e5ed4
ea74377
0302cc8
46cc5a9
2646a2d
073a5d5
e06d80b
fb706bd
5788ebf
966a338
8706a9f
2a48b0b
ba745f4
54f590f
549dfbe
aaa7040
8e72ce1
83e4c35
b56f7c7
cf0885d
dd456d0
58c739d
078508c
87b7f3e
7b18b51
acfdaeb
152ee66
ef365f3
e12968e
039acef
77ba655
b7ab032
fd0cf2d
08cf3ab
7d5c8fa
bc79f1d
0e5388a
489de4e
c56bb25
3ca7a4b
771c427
373c66f
e9d51ca
feab6fd
126631b
54fb391
57f1407
05a485b
4ea5056
068d5ae
e626b44
ba5ca7e
a152edb
c22189a
32ef210
7b5b7ff
85b07d0
4e11bd9
e309911
8cd3e71
1370523
36a107f
df3ae58
4a73ee3
c8c6e92
859e221
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Q] This looks like a workaround of some other problem (albeit non-critical). Can we resolve it right here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll need to regain access to a gfx94x machine before I can reassess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cderb [Recommendation] Fix kernel build warnings right here and revert this change.
As usual, "recommendations" are up to the author discretion. The author can actually resolve or just mark as resolved -- no explanation needed.