Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify TimeSeries #693

Closed
lars-reimann opened this issue May 2, 2024 · 0 comments
Closed

Simplify TimeSeries #693

lars-reimann opened this issue May 2, 2024 · 0 comments
Assignees
Labels
enhancement 💡 New feature or request

Comments

@lars-reimann
Copy link
Member

lars-reimann commented May 2, 2024

Is your feature request related to a problem?

In #680, we've drastically simplified the former TaggedTable (now TabularDataset). Similarly, TimeSeries should be simplified, which currently duplicates a lot of things one can already do with a Table.

Desired solution

  • Create a new TimeSeriesDataset class in safeds.data.labeled.containers. It should be created from a Table or a Mapping[str, Sequence[Any]] (see TabularDataset) by specifying
    • time_name
    • target_name
    • extra_names
  • Remove the current TimeSeries class completely. Instead, integrate the limited additional functionality to work with temporal data (e.g. plots) into the normal Table class.
  • Add a to_time_series_dataset method to Table, as an additional means to create a TimeSeriesDataset

This greatly improves maintainability. Moreover, then there's only one way to manipulate tabular data.

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 💡 New feature or request
Projects
Status: ✔️ Done
Development

No branches or pull requests

2 participants