Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests for Row and _LazyVectorizedRow #872

Closed
lars-reimann opened this issue Jun 28, 2024 · 1 comment · Fixed by #906
Closed

Improve tests for Row and _LazyVectorizedRow #872

lars-reimann opened this issue Jun 28, 2024 · 1 comment · Fixed by #906
Assignees
Labels
lab Suitable for the lab released Included in a release team2 testing 🧪 Additional automated tests

Comments

@lars-reimann
Copy link
Member

Tests for methods of Row (interface) and _LazyVectorizedRow (implementation) are missing entirely or for some edge cases.

We should

  • remove the outdated test_rows.py
  • create a folder tests/safeds/data/tabular/containers/
  • create individual files inside the folder for the different methods of Row (same structure as for other containers of tabular data).

Use parametrized tests to cover edge cases. Similar to assert_cell_operation_works for cells, a helper assert_row_operation_works can greatly simplify the implementation of the tests.

@lars-reimann lars-reimann added testing 🧪 Additional automated tests lab Suitable for the lab labels Jun 28, 2024
@franzitn franzitn added the team2 label Jul 12, 2024
@Muellersen Muellersen added team2 and removed team2 labels Jul 12, 2024
@Muellersen Muellersen linked a pull request Jul 12, 2024 that will close this issue
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lab Suitable for the lab released Included in a release team2 testing 🧪 Additional automated tests
Projects
Status: ✔️ Done
Development

Successfully merging a pull request may close this issue.

3 participants