From e1f2d6c30f69bd9fa5ce4a523bceec3d2748be0b Mon Sep 17 00:00:00 2001 From: Sedenion <39583823+Sedeniono@users.noreply.github.com> Date: Sat, 22 Jun 2024 09:53:17 +0200 Subject: [PATCH] Reenable the MSVC release builds on GitHub. According to https://github.com/actions/runner-images/issues/10004, the problems with the Windows runners have been fixed. They prevented successful runs for release builds. So this commit reverts 20c1fd8ba3d8324e46f2790c06a0384f54331026. --- .github/workflows/test_msvc_win.yml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/workflows/test_msvc_win.yml b/.github/workflows/test_msvc_win.yml index 82425e6..fd32f73 100644 --- a/.github/workflows/test_msvc_win.yml +++ b/.github/workflows/test_msvc_win.yml @@ -23,12 +23,7 @@ jobs: # in the solution file. In other words, the values do not correspond directly to compiler # switches but instead to parts of the configuration names from the .sln file. cpp_version: [C++17, C++20] - # The Windows GitHub runner is broken for release builds. There are crashes in std::mutex - # because they haven't installed the latest Visual C++ Redistributable after updating - # Visual Studio to 17.10. See https://github.com/actions/runner-images/issues/10004 - # Until GitHub updates the runner, we simply disable release builds. - buildmode: [Debug] - #buildmode: [Debug, Release] + buildmode: [Debug, Release] include: - cpp_version: "C++17 permissive"