Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have dfp_date_to_list() infer the timezone if provided in the date time #6

Closed
StevenMMortimer opened this issue Apr 18, 2018 · 0 comments
Closed

Have dfp_date_to_list() infer the timezone if provided in the date time #6

StevenMMortimer opened this issue Apr 18, 2018 · 0 comments
Assignees
@StevenMMortimer
Labels
enhancement Feature request
Milestone
0.1.3

Comments

@StevenMMortimer
Copy link
Owner

StevenMMortimer commented Apr 18, 2018 •
edited
Loading

Currently the function dfp_date_to_list() has an argument for the timezone that defaults to America/New_York. It would be nice if this used the timezone of the object passed in if it has one. A better default might be the system default timezone if one is not provided.

TODO: Look at feasibility for getting the complete list of timezone ids and mapping them to R equivalents.
@StevenMMortimer StevenMMortimer self-assigned this May 26, 2018
@StevenMMortimer StevenMMortimer added the enhancement Feature request label May 26, 2018
@StevenMMortimer StevenMMortimer added this to the 0.1.3 milestone May 26, 2018
@StevenMMortimer StevenMMortimer modified the milestones: 0.1.3, Future Jul 31, 2018
@StevenMMortimer StevenMMortimer modified the milestones: Future, 0.1.3 Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StevenMMortimer StevenMMortimer

Labels
enhancement Feature request
Projects
None yet
Milestone
0.1.3
Development

No branches or pull requests
1 participant
@StevenMMortimer