Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper opens dozens of pull requests #215

Closed
rikhuijzer opened this issue Jul 24, 2021 · 4 comments
Closed

CompatHelper opens dozens of pull requests #215

rikhuijzer opened this issue Jul 24, 2021 · 4 comments

Comments

@rikhuijzer
Copy link
Contributor

rikhuijzer commented Jul 24, 2021

Currently, the tutorials all have their own environment. This causes CompatHelper to open dozens of pull requests when multiple dependencies should be updated. Even when these are resolved, one new package version may introduce 10 new pull requests (one per tutorial).

I would suggest moving to one global environment to avoid spamming the 10 people who watch this repository, but I also understand that there are drawbacks to having one environment.

@devmotion, @torfjelde, @cpfiffer, any thoughts?

EDIT: Apologies for the mess this has caused, by the way. I could have predicted that we would end up with 87 PRs.

@torfjelde
Copy link
Member

torfjelde commented Jul 24, 2021

If that's the only alternative (what do they do over at SciML?), then IMO we should instead just not use CompatHelper here. Global env is unfortuante because eventually we'll have a lot of deps for all tutorials leading to unnecessary bloat, increased compile-times, etc. IMO we want the tutorials to be something people can actually open up and play around with; a global env IMO goes against that.

@devmotion
Copy link
Member

Global env is unfortuante because eventually we'll have a lot of deps for all tutorials leading to unnecessary bloat, increased compile-times, etc. IMO we want the tutorials to be something people can actually open up and play around with; a global env IMO goes against that.

I agree, IMO we should really not use a global environment. It leads to a lot of unnecessary dependencies for individual tutorials, makes it more difficult to update the tutorials, and increases the probability of package conflicts. If the packages are somewhat mature, hopefully breaking updates don't occur too often and we just have to cope with the PRs (if we do not rebuild all tutorials it will also not put too much stress on GH actions).

@rikhuijzer
Copy link
Contributor Author

Okay. I’m convinced. Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants