Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect library version and filename in 4.9.0 #2390

Open
sebastic opened this issue Jun 11, 2022 · 4 comments
Open

Incorrect library version and filename in 4.9.0 #2390

sebastic opened this issue Jun 11, 2022 · 4 comments
Assignees
Milestone

Comments

@sebastic
Copy link
Contributor

The CMake build for NetCDF 4.9.0 uses the wrong library version which causes the wrong filename to be used:

-rw-r--r-- root/root   1424472 2022-06-11 08:35 ./usr/lib/x86_64-linux-gnu/libnetcdf.so.19}
lrwxrwxrwx root/root         0 2022-06-11 08:35 ./usr/lib/x86_64-linux-gnu/libnetcdf.so.19 -> libnetcdf.so.19}

This patch fixes the issue:

--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -39,7 +39,7 @@ SET(NC_VERSION ${netCDF_VERSION})
 SET(PACKAGE_VERSION ${VERSION})
 
 # These values should match those in configure.ac
-SET(netCDF_LIB_VERSION 19})
+SET(netCDF_LIB_VERSION 19)
 SET(netCDF_SO_VERSION 19)
 
 # Version of the dispatch table. This must match the value in
@edwardhartnett
Copy link
Contributor

Oh oh!

@WardF
Copy link
Member

WardF commented Jun 11, 2022

This is a problem, I will see what we can do.

@WardF
Copy link
Member

WardF commented Jun 11, 2022

I've added a note, and will add the fix. It's not as disastrous as my initial impression since we still have the symbolic links, so it's also not great. But a very good catch, thank you!

@WardF WardF self-assigned this Jun 11, 2022
@WardF WardF added this to the 4.9.1 milestone Jun 11, 2022
@dopplershift
Copy link
Member

Looks like this one has been addressed and could be closed out.

@WardF WardF modified the milestones: 4.9.1, 4.9.2 Feb 13, 2023
@WardF WardF modified the milestones: 4.9.2, 4.9.3 May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants