Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend length of Textfield to full length of search box...? #4

Closed
juddey opened this issue Jul 9, 2019 · 5 comments
Closed

Extend length of Textfield to full length of search box...? #4

juddey opened this issue Jul 9, 2019 · 5 comments
Assignees
Labels
enhancement New feature or request fixed good first issue Good for newcomers

Comments

@juddey
Copy link

juddey commented Jul 9, 2019

Hello, using your lib, thanks for making it!

I've found a small annoyance and I'm wondering if you can assist. When you click on the search box anywhere other than the direct 'Search...' text, the onPress handler activates. I'm not sure if this was by design, but i'd expect a press on a search box to activate the keyboard or something similar, otherwise you just get a press action, and what seems like no result.

I've created the video below to demonstrate the problem. In this screen cap I'm clicking in between the search text and the X (cancel), and you can see the "meaningless" press.

untitled

Is there any chance this behaviour could be changed?

@WrathChaos
Copy link
Owner

Hello @juddey,
I also noticed that annoying action :) I will try to fix it or at least make an option to disable the annoying "onPress" action. Actually, In one of my projects search bar's onPress is also a need therefore, I make it like that. I will fix it ASAP.

Thank you for using it :)

@WrathChaos WrathChaos self-assigned this Jul 9, 2019
@WrathChaos WrathChaos added enhancement New feature or request good first issue Good for newcomers labels Jul 9, 2019
@WrathChaos
Copy link
Owner

Hello @juddey,
I fixed it and provides a good feature for it: onPressToFocus.
You can see the new release:

Release: 0.2.0

Please check it out and give me feedback for it :)

@WrathChaos
Copy link
Owner

I just closed the issue, please give me a feedback about the new version 0.2.0 :) If you need anything feels free to open a new issue.

@juddey
Copy link
Author

juddey commented Jul 10, 2019

Thanks @WrathChaos! I will give it a try and let you know.
Update: I have tried it, and it works well, I have used the onPressToFocus prop :shipit:

@WrathChaos
Copy link
Owner

@juddey I love to hear that :) If you need something else, open an issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants