Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] comServer+toastNotificationActivation support #94

Closed
azchohfi opened this issue Feb 7, 2022 · 9 comments
Closed

[FEATURE REQUEST] comServer+toastNotificationActivation support #94

azchohfi opened this issue Feb 7, 2022 · 9 comments
Labels
enhancement New feature or request fixed bug fixed
Milestone

Comments

@azchohfi
Copy link
Contributor

azchohfi commented Feb 7, 2022

💬 Description

If your app is using toast notifications, your manifest needs to define a comServer extension, as well as a toastNotificationActivation extension, given a specific CLSID (https://docs.microsoft.com/en-us/windows/apps/design/shell/tiles-and-notifications/send-local-toast-desktop-cpp-wrl#msixsparse-package). There is no way to specify such things in the cli, nor in the pubspec.yaml.

❓ Platform

Windows

@azchohfi
Copy link
Contributor Author

azchohfi commented Feb 7, 2022

I think I'll send a PR to support these things.

@YehudaKremer
Copy link
Owner

Hello @azchohfi

I'm currently working on adding App Installer (updates outside of the Microsoft store) in this branch,
after that, i will be glad to add this nice feature.

You more then welcome to add features to this package 👍
if you do, please make branch from 3.0v (not the main branch).

how we can implement this toast feature in the yaml file?
you can do something similar to what I'm planning for the AppInstaller feature, see this code, then the yaml will look like this:

msix_config:
  display_name: MyApp
  publisher_display_name: MyApp
  app_installer:
    publish_folder_path: C:/some/path
    installer_path: C:/some/path2
    show-prompt: true
  identity_name: de.myapp2.test
  msix_version: 1.0.3.0

@YehudaKremer YehudaKremer added the enhancement New feature or request label Feb 7, 2022
@YehudaKremer YehudaKremer added this to the 3.0 milestone Feb 7, 2022
@azchohfi
Copy link
Contributor Author

azchohfi commented Feb 7, 2022

I was thinking about having something very simple, such as a toast-activator-clsid param, but I believe I will need to add something similar to what you have, to be able to customize the arguments and the display name. I'll branch from 3.0v and send the PR!

@YehudaKremer
Copy link
Owner

How so fast?! :)

code reviewing..

@azchohfi
Copy link
Contributor Author

azchohfi commented Feb 7, 2022

The code is already very well written, so adding a new option was quite an easy addition. 😊

@YehudaKremer
Copy link
Owner

YehudaKremer commented Feb 7, 2022

I'm glad to hear that, I'm planning (3.0v) more refactoring for more code simplicity.
You catch me on the way to bed🛌, will review it tomorrow..

Thanks

@YehudaKremer
Copy link
Owner

Hello @azchohfi

I added some documentations about the toast notifications,
and also publish it in version 3.0.0-dev.3

do you have any example of an app with toast notifications that you can use 3.0.0-dev.3? i would like to see it in action 🎉

@azchohfi
Copy link
Contributor Author

azchohfi commented Feb 8, 2022

I do not have a Flutter app with it just yet. I'm porting a plugin to support Windows that will need this for the Microsoft Store/MSIX, so I just wanted this to not be a blocker for it. This is definitely what is needed for push notifications, and I will definitely git it a try in a few weeks. Thanks for the quick review!

@YehudaKremer YehudaKremer added the fixed bug fixed label Feb 12, 2022
@graylandl
Copy link

@azchohfi Did you ever get an example for this running? Or is the package win_toast required to integrate platform notifications? I'm working with the WINRT library but I don't yet understand the activator portion of things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request fixed bug fixed
Projects
None yet
Development

No branches or pull requests

3 participants