Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copied on-chain addresses should not begin with "bitcoin:" #1359

Closed
NateNate60 opened this issue Mar 11, 2023 · 1 comment
Closed

Copied on-chain addresses should not begin with "bitcoin:" #1359

NateNate60 opened this issue Mar 11, 2023 · 1 comment
Labels
Bug Something isn't working

Comments

@NateNate60
Copy link

Describe the bug

When copying Bitcoin addresses from the "request payment" flow, the copied address beings with "bitcoin:". This is not canonically part of a Bitcoin address and therefore is not compliant with BIP 173 and BIP 13. Indeed, most Bitcoin wallets will actually reject such an address as invalid, requiring the user to paste the address somewhere else first and manually delete the "bitcoin:" prefix.

Additionally, the copied address for P2WPKH (Bech32 native Segwit addresses) is all capitalised. This is unusual and most other implementations of this address format use all-lowercase characters instead. This isn't a bug and most wallets do still accept it, but it just looks strange.

Reproduce

Go to the balances tab on the left, tap "on-chain", then "receive", then enter any information. Select "on-chain", then copy the address. The copied address will begin with bitcoin:.

Zeus version

v0.7.3

Node interface

LND (REST)

Network

Clearnet

Device

OnePlus Nord N20

Device operating system

Android 12

Log output

No response

@NateNate60 NateNate60 added the Bug Something isn't working label Mar 11, 2023
@kaloudis
Copy link
Contributor

kaloudis commented Apr 1, 2023

This behavior has been changed in v0.7.4

@kaloudis kaloudis closed this as completed Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants