accepted 2xx in response code as success #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nasir-rabbani
requested review from
devang-gaur,
patilpankaj212,
kanchwala-yusuf and
Rchanger
nasir-rabbani
force-pushed
the
fix-webhook-respcode
branch
from
ada2dbd
to
0b780f1
Compare
devang-gaur
suggested changes
Oct 6, 2021
I tried, it failed. |
Codecov Report
@@ Coverage Diff @@
## master #1040 +/- ##
=======================================
Coverage 78.18% 78.18%
=======================================
Files 237 237
Lines 6299 6299
=======================================
Hits 4925 4925
Misses 1069 1069
Partials 305 305
|
devang-gaur
suggested changes
Oct 6, 2021
kanchwala-yusuf
previously approved these changes
Oct 6, 2021
devang-gaur
previously approved these changes
Oct 6, 2021
nasir-rabbani
dismissed stale reviews from devang-gaur and kanchwala-yusuf
via
26f18bf
nasir-rabbani
force-pushed
the
fix-webhook-respcode
branch
from
26f18bf
to
0b780f1
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
kanchwala-yusuf
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will accept any http response code in range of 2xx from webhook as success.