Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config file changes for terrascan server #780

Merged

Conversation

patilpankaj212
Copy link
Contributor

  1. fix issue with global config
  2. make changes in server code to remove reading config file
  3. unit tests

@sonarcloud
Copy link

sonarcloud bot commented May 13, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@patilpankaj212 patilpankaj212 linked an issue May 13, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #780 (f24ad33) into master (01c8d78) will increase coverage by 1.11%.
The diff coverage is 60.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #780      +/-   ##
==========================================
+ Coverage   73.78%   74.90%   +1.11%     
==========================================
  Files         110      110              
  Lines        3285     3300      +15     
==========================================
+ Hits         2424     2472      +48     
+ Misses        677      644      -33     
  Partials      184      184              
Impacted Files Coverage Δ
pkg/cli/server.go 50.00% <0.00%> (ø)
pkg/http-server/start.go 0.00% <0.00%> (ø)
pkg/http-server/webhook-scan-logs.go 0.00% <0.00%> (ø)
pkg/config/global.go 79.45% <61.90%> (-7.09%) ⬇️
pkg/http-server/handler.go 100.00% <100.00%> (ø)
pkg/http-server/routes.go 100.00% <100.00%> (ø)
pkg/http-server/webhook-scan.go 70.00% <100.00%> (ø)
pkg/k8s/admission-webhook/validating-webhook.go 83.44% <100.00%> (+21.44%) ⬆️
pkg/k8s/dblogs/webhook-scan-logger.go 78.18% <0.00%> (+7.27%) ⬆️

@patilpankaj212 patilpankaj212 requested review from kanchwala-yusuf and devang-gaur and removed request for kanchwala-yusuf May 13, 2021 12:23
@devang-gaur
Copy link
Contributor

Is it a refactor? or a change in config? I don't see any changes to the TerrascanConfig struct. Its probably a refactor as per mey understanding.

@patilpankaj212

@kanchwala-yusuf kanchwala-yusuf merged commit a3f26c1 into tenable:master May 17, 2021
@patilpankaj212 patilpankaj212 deleted the config-file-changes-server branch May 18, 2021 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config file changes for server and admission controller
3 participants