Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes touch_with_version re: the :on option #563

Merged
merged 1 commit into from
Jul 9, 2015

Conversation

jaredbeck
Copy link
Member

Fixes a bug where touch_with_version fails to create a version.

Table: Is a version created?
The :on option Without PR With PR
nil yes yes
[] yes yes
[:update] yes yes
[:create] no yes

Fixes a bug where e.g. `on: [:create, :destroy]` (not :update)
failed to create a version.
@jaredbeck jaredbeck added this to the 4.0.0 milestone Jul 9, 2015
@jaredbeck jaredbeck mentioned this pull request Jul 9, 2015
@batter
Copy link
Collaborator

batter commented Jul 9, 2015

You're a rock star! Great find, thanks for taking initiative on this one.

batter added a commit that referenced this pull request Jul 9, 2015
Fixes `touch_with_version` re: the `:on` option
@batter batter merged commit cc3f639 into master Jul 9, 2015
@batter batter deleted the clarify_touch_with_version branch July 9, 2015 21:02
@jaredbeck
Copy link
Member Author

You're a rock star! Great find, thanks for taking initiative on this one.

Aw gee shucks :) Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants