Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move kafka-grpc options for grpc to with section of config #218

Closed
jfallows opened this issue Apr 24, 2023 · 0 comments · Fixed by #219
Closed

Move kafka-grpc options for grpc to with section of config #218

jfallows opened this issue Apr 24, 2023 · 0 comments · Fixed by #219
Assignees
Labels
enhancement New feature or request

Comments

@jfallows
Copy link
Contributor

In general, the options and when sections of binding should describe concepts aligned with the origin type, such as kafka in the case of kafka-grpc, and the with section should describe concepts aligned with the routed type, such as grpc in the case of kafka-grpc.

We need to move the kafka-grpc options for scheme and authority to with section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants