Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 1-1 helm chart versioning strategy #487

Closed
jfallows opened this issue Oct 2, 2023 · 0 comments · Fixed by #489
Closed

Use 1-1 helm chart versioning strategy #487

jfallows opened this issue Oct 2, 2023 · 0 comments · Fixed by #489
Assignees
Labels
enhancement New feature or request

Comments

@jfallows
Copy link
Contributor

jfallows commented Oct 2, 2023

Today, our helm chart has the following default image tag and pull policy.

image:
repository: ghcr.io/aklivity/zilla
pullPolicy: IfNotPresent
tag: latest

We prefer to make the chart version and zilla (app) version align 1-1, rather than pulling latest by default.

The pull policy can most likely be removed from values.yaml to pick up the default default behavior, which is IfNotPresent for versioned tags and Always for latest tag.

The tag can be changed to match the zilla release version. Note unless directly supported by the Maven docker plugin, this requires use of Maven filtered resources to inject ${project.version} into values.yaml during the zilla helm-chart build instead of the literal latest tag value.

Suggest including a ZILLA_VERSION environment variable with value coming from ${project.version} that simplifies detection of the current version as well.

@jfallows jfallows added the enhancement New feature or request label Oct 2, 2023
@vordimous vordimous self-assigned this Oct 2, 2023
@vordimous vordimous linked a pull request Oct 3, 2023 that will close this issue
@jfallows jfallows assigned attilakreiner and unassigned vordimous Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants