Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus schema Port and tcp schema Port have different validation #569

Closed
vordimous opened this issue Nov 9, 2023 · 0 comments · Fixed by #587
Closed

prometheus schema Port and tcp schema Port have different validation #569

vordimous opened this issue Nov 9, 2023 · 0 comments · Fixed by #587
Assignees
@attilakreiner

Comments

@vordimous
Copy link
Contributor

Describe the bug
The yaml validator in the vscode extension shows an error. The Prometheus schema validation is for type "int" where the TCP validators have both "integer" and a string regex.

Expected behavior
Port is correctly validated

fixes https://github.com/aklivity/zilla-vscode-ext/issues/16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@attilakreiner attilakreiner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix prometheus exporter schema attilakreiner/zilla
2 participants
@vordimous @attilakreiner