You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I understand the scope of this action relates only to PR titles and there are alternatives for those wishing to lint commit messages in general. However, I wonder if you'd consider an optional extra validation step for PRs with only one commit.
When squashing and merging these PRs, GitHub suggests the commit message instead of the PR title, and if you aren't careful the PR will be merged without a conventional commit causing semantic release to ignore it.
I'm happy to put in a PR for this as I'd use it at work.
My suggestion would be an extra boolean configuration option validateSingleCommit. If the PR title passes validation and validateSingleCommit is true, we get the list of commits and pass if length > 1. Otherwise validate the commit message.
The text was updated successfully, but these errors were encountered:
I understand the scope of this action relates only to PR titles and there are alternatives for those wishing to lint commit messages in general. However, I wonder if you'd consider an optional extra validation step for PRs with only one commit.
When squashing and merging these PRs, GitHub suggests the commit message instead of the PR title, and if you aren't careful the PR will be merged without a conventional commit causing semantic release to ignore it.
I'm happy to put in a PR for this as I'd use it at work.
My suggestion would be an extra boolean configuration option
validateSingleCommit
. If the PR title passes validation andvalidateSingleCommit
is true, we get the list of commits and pass iflength > 1
. Otherwise validate the commit message.The text was updated successfully, but these errors were encountered: