Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validating the commit message for single commit PRs #86

Closed
simlrh opened this issue Feb 12, 2021 · 1 comment · Fixed by #87
Closed

Validating the commit message for single commit PRs #86

simlrh opened this issue Feb 12, 2021 · 1 comment · Fixed by #87

Comments

@simlrh
Copy link
Contributor

simlrh commented Feb 12, 2021

I understand the scope of this action relates only to PR titles and there are alternatives for those wishing to lint commit messages in general. However, I wonder if you'd consider an optional extra validation step for PRs with only one commit.

When squashing and merging these PRs, GitHub suggests the commit message instead of the PR title, and if you aren't careful the PR will be merged without a conventional commit causing semantic release to ignore it.

I'm happy to put in a PR for this as I'd use it at work.

My suggestion would be an extra boolean configuration option validateSingleCommit. If the PR title passes validation and validateSingleCommit is true, we get the list of commits and pass if length > 1. Otherwise validate the commit message.

@github-actions
Copy link

🎉 This issue has been resolved in version 3.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant