Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Stories “Get link” returns foreign language characters as encoded URL in story bookend #38510

Closed
LuckynaSan opened this issue Oct 25, 2022 · 1 comment

Comments

@LuckynaSan
Copy link

Description

The story bookend is displayed with HTML markup when the story title or permalink slug contains language special characters.

Example story URL: https://feignednorth.s4-tastewp.com/web-stories/%e0%b0%87%e0%b0%82%e0%b0%a1%e0%b0%bf%e0%b0%af%e0%b0%be-%e0%b0%b8%e0%b0%bf%e0%b0%ae%e0%b1%86%e0%b0%82%e0%b0%9f%e0%b1%8d%e0%b0%b8%e0%b1%8d-%e0%b0%aa%e0%b1%88%e0%b0%a8-%e0%b0%95%e0%b1%87%e0%b0%b8/

Reproduction Steps

  1. Create a new Web Story
  2. Use “ఇండియా-సిమెంట్స్-పైన-కేస” as title
  3. Publish the story.
  4. View story
  5. Click Share icon > Get Link. Note URL copied contains HTML markup.

image

Relevant Logs

No response

Browser(s) Affected

No response

OS(s) Affected

No response

Device(s) Affected

No response

AMP Version Affected

No response

@newmuis
Copy link
Contributor

newmuis commented Oct 25, 2022

I believe this is actually the correct behavior, as these characters are URL encoded to ensure compatibility across systems. The only characters that are guaranteed not to require encoding in URLs are the unreserved characters. We rely on the end user's web browser to provide the URL encoding when copying the link.

These URLs are otherwise equivalent, and both should work.

@newmuis newmuis closed this as completed Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants