-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend npm install problems (lyft repository dependencies) #2141
Comments
Thanks for opening your first issue here! |
I came across this issue once as well and saw some occurrences of people facing this in the amundsen slack channel too ... |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This might be a nitpick, but to me, the "stale bot" does not seem to make a lot of sense. It just makes it obvious that replies are taking some time... Which I am totally ok with, by the way. Why shouldn't it be ok if there is no reply to an issue for 2 weeks ? Does not seem like auto closing issues helps with anything. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
It is still happening, it is connecting to https://artifactory-npm.lyft.net/artifactory/api/npm/virtual-npm-lyft/tree-changes/-/t |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Definitely a bug. |
Check #2174 for a fix |
Thank you for the fix |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
I was trying to build the static part of the amundsen frontend like outlined in the documentation
This leads to a E401 errors from npm.
Current Behavior
Some of the dependencies in
package-lock.json
are resolved to a repository hosted by lyft.This leads to problems building because it seems this is not open for public.
Example:
react-switch
is resolved tohttps://artifactory-npm.lyft.net/artifactory/api/npm/virtual-npm-lyft/react-switch/-/react-switch-6.0.0.tgz
which requires some kind of login to access.Not sure what the reason for this is, but it seems like all of these dependencies could also be resolved by a public repository.
For Example
react-switch
could be resolved fromhttps://registry.npmjs.org/react-switch/-/react-switch-6.0.0.tgz
Possible Solution
It is of course possible to delete
package-lock.json
and rebuild it however this makes it much more complicated to get a working configuration. Manually changing the file for just a couple of dependencies is also not a great solution.My proposal would be to change
package-lock.json
to only resolved dependencies to public available repositories.The text was updated successfully, but these errors were encountered: