Skip to content

Commit

Permalink
axi_dmac: dest_axi_mm: Simplify dependency management
Browse files Browse the repository at this point in the history
There is an implicit dependency between the outgoing data stream and the
incoming response stream. The AXI specification requires that the
corresponding response is not sent before the last beat of data has been
received.

We can take advantage of this and remove the currently explicit dependency
between the data and response paths. This slightly simplifies the design.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
  • Loading branch information
larsclausen authored and Lars-Peter Clausen committed Jul 3, 2018
1 parent 8c1d8e2 commit fa99afc
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions library/axi_dmac/dest_axi_mm.v
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ wire data_req_valid;
wire data_req_ready;

wire address_enabled;
wire data_enabled;

splitter #(
.NUM_M(2)
Expand Down Expand Up @@ -161,8 +160,9 @@ dmac_data_mover # (
.clk(m_axi_aclk),
.resetn(m_axi_aresetn),

.enable(address_enabled),
.enabled(data_enabled),
/* Unused. AXI protocol guarantees ordering */
.enable(1'b1),
.enabled(),

.xfer_req(),

Expand Down Expand Up @@ -194,11 +194,11 @@ dmac_response_handler #(
.bready(m_axi_bready),
.bresp(m_axi_bresp),

.enable(data_enabled),
.enable(address_enabled),
.enabled(enabled),

.id(response_id),
.request_id(data_id),
.request_id(address_id),

.eot(response_eot),

Expand Down

0 comments on commit fa99afc

Please sign in to comment.